[feature] add sms config #2399
[feature] add sms config #2399
Conversation
common/src/main/java/org/apache/hertzbeat/common/constants/SmsTypeEnum.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/apache/hertzbeat/common/constants/SmsTypeEnum.java
Outdated
Show resolved
Hide resolved
hi, yes there is no alibaba sms code, due the alibab sdk import too much irrelevant third-party dependencies. We plan to remove the SDKs of these cloud vendors and use the rest api to implement it |
|
hi，how about i remove backend’s modification, just keep web ui
…---- Replied Message ----
| From | ***@***.***> |
| Date | 07/29/2024 12:25 |
| To | apache/hertzbeat ***@***.***> |
| Cc | aias00 ***@***.***>,
Author ***@***.***> |
| Subject | Re: [apache/hertzbeat] [feature] add sms config (PR #2399) |
which supports two types of sms providers(tencent\alibaba) for selecting, but i just achieved tencent sms, cause i found no alibaba`s config in code .
hi, yes there is no alibaba sms code, due the alibab sdk import too much irrelevant third-party dependencies. We plan to remove the SDKs of these cloud vendors and use the rest api to implement it
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
ok 👍 suggest also remove sms config doc here https://hertzbeat.apache.org/docs/start/custom-config |
okay, cool |
|
|
now people can modify sms config by web ui , and the config can be persistenced. that`s all |
|
i18n is also done by the way |
What's changed?
add sms config in web app #1020 & backend
which supports two types of sms providers(tencent\alibaba) for selecting, but i just achieved tencent sms, cause i found no alibaba`s config in code .
Checklist
Add or update API