[refactor] move code from MetricsDataController to MetricsService #2437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Calvin979
reviewed
Aug 5, 2024
| public MetricsData getMetricsData(Long monitorId, String metrics) { | ||
| boolean available = realTimeDataReader.isServerAvailable(); | ||
| if (!available) { | ||
| throw new CommonException("real time store not available"); |
There was a problem hiding this comment.
Looks like this CommonException is not catched by MetricsDataController.
There was a problem hiding this comment.
CommonException is caught by the GlobalExceptionHandler in Manager, making sure it is the same as before, and throwing an exception forward when it is not available
|
|
||
| /** | ||
| * | ||
| */ |
There was a problem hiding this comment.
Could you help complete comment here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Checklist
Add or update API