Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] add greenplum template #2442

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

Aias00
Copy link
Contributor

@Aias00 Aias00 commented Aug 2, 2024

What's changed?

add greenplum template
image
image
image

see https://greenplum.org/

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! can help add metrics i18n?
eg:

  - name: sort
    priority: 2
    i18n:
      zh-CN: 排序 信息
      en-US: Sort Info
    fields:
      - field: sort_rows
        type: 0
        i18n:
          zh-CN: 排序总行数
          en-US: Sort Rows

@tomsun28 tomsun28 merged commit c85e182 into apache:master Aug 2, 2024
3 checks passed
@tomsun28 tomsun28 added the good first pull request Good for newcomers label Aug 2, 2024
@tomsun28 tomsun28 added this to the 1.6.1 milestone Aug 2, 2024
@Aias00
Copy link
Contributor Author

Aias00 commented Aug 2, 2024

lgtm! can help add metrics i18n? eg:

  - name: sort
    priority: 2
    i18n:
      zh-CN: 排序 信息
      en-US: Sort Info
    fields:
      - field: sort_rows
        type: 0
        i18n:
          zh-CN: 排序总行数
          en-US: Sort Rows

okay, i will add them later

@Aias00 Aias00 deleted the feature/add_greenplum branch August 2, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants