Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve] add i18n for postgresql\kingbase\greenplum #2448

Merged
merged 6 commits into from
Aug 3, 2024
Merged

[improve] add i18n for postgresql\kingbase\greenplum #2448

merged 6 commits into from
Aug 3, 2024

Conversation

Aias00
Copy link
Contributor

@Aias00 Aias00 commented Aug 3, 2024

What's changed?

add i18n for postgresql\kingbase\greenplum

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@Aias00
Copy link
Contributor Author

Aias00 commented Aug 3, 2024

hi, my workflow errors several times at this step, and i don`t konw why
image

@yuluo-yx
Copy link
Member

yuluo-yx commented Aug 3, 2024

hi, my workflow errors several times at this step, and i don`t konw why image

I've submitted a pr to fix it. pls see: #2447

@Aias00
Copy link
Contributor Author

Aias00 commented Aug 3, 2024

hi, my workflow errors several times at this step, and i don`t konw why image

I've submitted a pr to fix it. pls see: #2447

hi, nice one 👍👍👍

@yuluo-yx
Copy link
Member

yuluo-yx commented Aug 3, 2024

hi, nice one 👍👍👍

tks, if has any problem, pls @ me.

@tomsun28 tomsun28 added doc Improvements or additions to documentation good first pull request Good for newcomers labels Aug 3, 2024
tomsun28
tomsun28 approved these changes Aug 3, 2024
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@tomsun28 tomsun28 merged commit de657f9 into apache:master Aug 3, 2024
3 checks passed
@Aias00 Aias00 deleted the feature/add_i18n branch August 4, 2024 05:08
@Aias00 Aias00 mentioned this pull request Aug 4, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
backend doc Improvements or additions to documentation good first pull request Good for newcomers monitoring-template
Projects
Apache HertzBeat (Incubating)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Aias00 @yuluo-yx @tomsun28