Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] refactor connect common cache #2469

Merged
merged 6 commits into from
Aug 8, 2024
Merged

[refactor] refactor connect common cache #2469

merged 6 commits into from
Aug 8, 2024

Conversation

tomsun28
Copy link
Contributor

@tomsun28 tomsun28 commented Aug 5, 2024

What's changed?

refactor connect common cache

todo combine use one common cache instead of every collect create one.

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

Signed-off-by: tomsun28 <tomsun28@outlook.com>
Signed-off-by: tomsun28 <tomsun28@outlook.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 28.50%. Comparing base (7a7d479) to head (fc92628).

Files Patch % Lines
...or/collect/common/cache/ConnectionCommonCache.java 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2469      +/-   ##
============================================
+ Coverage     28.47%   28.50%   +0.02%     
+ Complexity     1593     1592       -1     
============================================
  Files           429      429              
  Lines         17718    17697      -21     
  Branches       2309     2307       -2     
============================================
- Hits           5045     5044       -1     
+ Misses        12095    12075      -20     
  Partials        578      578              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@crossoverJie crossoverJie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomsun28 tomsun28 merged commit 3113487 into master Aug 8, 2024
3 checks passed
@zqr10159 zqr10159 deleted the update-cache branch September 23, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants