Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[type:improve] add windows i18n #2513

Merged
merged 7 commits into from
Aug 13, 2024
Merged

[type:improve] add windows i18n #2513

merged 7 commits into from
Aug 13, 2024

Conversation

Aias00
Copy link
Contributor

@Aias00 Aias00 commented Aug 12, 2024

What's changed?

add windows i18n

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

yuluo-yx
yuluo-yx approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@yuluo-yx yuluo-yx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tomsun28 tomsun28 merged commit 35616d2 into apache:master Aug 13, 2024
2 of 3 checks passed
@Aias00 Aias00 deleted the feature/add_win_i18n branch August 16, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuluo-yx yuluo-yx yuluo-yx approved these changes

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
backend monitoring-template
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Aias00 @tomsun28 @yuluo-yx @Calvin979