[improve]improve code #2523
Merged
[improve]improve code #2523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomsun28
reviewed
Aug 18, 2024
Comment on lines
75
to
78
| public JmxCollectImpl() { | ||
| connectionCommonCache = new ConnectionCommonCache<>(); | ||
| Thread.currentThread().setContextClassLoader(new ClassLoaderConfig(ClassLoader.getSystemClassLoader())); | ||
| } |
There was a problem hiding this comment.
Hi, this seem can not work due the constructor new JmxCollectImpl() is call by the thread-A and JmxCollectImpl is singleton, but the JmxCollectImpl.collect is run by another thread-B in running-thread-pool. Thread.currentThread().setContextClassLoader only can take effect on the current thread.
Signed-off-by: tomsun28 <tomsun28@outlook.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2523 +/- ##
============================================
- Coverage 28.65% 28.62% -0.03%
+ Complexity 1640 1639 -1
============================================
Files 445 446 +1
Lines 18121 18133 +12
Branches 2338 2339 +1
============================================
- Hits 5192 5191 -1
- Misses 12340 12354 +14
+ Partials 589 588 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
improve code
Checklist