[Feature] Supports Bulletin to view all metrics. #2584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement new monitor bulletin functionality. - Add corresponding UI components for bulletin management. - Update app-data.json to include new menu item for monitor bulletin. - Refactor bulletin.component.html and .spec.ts files.
- Create Bulletin.java class with Monitor, Status, and Metrics fields. - Add BulletinService.java interface defining methods for bulletin operations.
…tions. - Create Bulletin.java with JPA annotations for database mapping. - Add BulletinDao interface extending JpaRepository and JpaSpecificationExecutor. - Implement BulletinServiceImpl with methods for bulletin operations. - Update BulletinController with new endpoints for bulletin management. - Refactor AlertDefinesController to remove unnecessary search criteria.- Add and modify tests for BulletinService and BulletinDao. BREAKING CHANGE: This commit introduces changes to the database schema and requires migration for existing databases to incorporate the Bulletin entity.
…ations.- Create Bulletin.java with JPA annotations for database mapping. - Add BulletinDao interface extending JpaRepository and JpaSpecificationExecutor. - Implement BulletinServiceImpl with methods for bulletin operations. - Update BulletinController with new endpoints for bulletin management. - Refactor AlertDefinesController to remove unnecessary search criteria. - Add and modify tests for BulletinService and BulletinDao. BREAKING CHANGE: This commit introduces changes to the database schema and requires migration for existing databases to incorporate the Bulletin entity.
Implement the Bulletin entity with JPA annotations for database mapping, along with a service layer for bulletin operations. Update the controller and tests accordingly. BREAKING CHANGE: This commit introduces changes to the database schema and requires migration for existing databases to incorporate the Bulletin entity.
Introduce a dropdown menu in the bulletin component for improved user interaction. The dropdown offers multiple options for users to select and submit as part of the bulletin form.
Implement a new endpoint `/apps/defines` in the backend to support retrieving application definitions. Extend the `AppController` and `AppService` with new methods to handle this functionality. Additionally, introduce internationalization (i18n) support for application names, providing localized versions of app names in the frontend.The frontend `AppDefineService` has been updated to consume the new endpoint and manage the application define list. Changes in the `bulletin.component.html` and `bulletin.component.ts` files include the renaming of variables and the addition of new functionality to handle the application define selection. BREAKING CHANGE: The introduction of i18n support changes the data structure and may affect existing clients that rely on the previous format.
Replace the existing metric dropdown in the bulletin component with a tree structure to facilitate hierarchical metric selection. This new interface allows users to navigate and choose metrics in a more intuitive and visual manner.
Replace the metric dropdown in the bulletin component with a transfer component to improve the user experience for selecting metrics. The new transfer component allows users to easily navigate and transfer metrics between different categories.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has checked 2568 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 1099 | 2 | 1467 | 0 |
Click to see the invalid file list
- manager/src/main/java/org/apache/hertzbeat/manager/service/impl/BulletinServiceImpl.java
- web-app/src/app/pojo/Fields.ts
Use this command to fix any missing license headers
```bash
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
</details>
manager/src/main/java/org/apache/hertzbeat/manager/service/impl/BulletinServiceImpl.java
Show resolved
Hide resolved
Code refactor includes: - Standardizing import statements across various files by removing unused imports and adjusting import formatting for consistency. - Consolidating and organizing the components within modules for better readability and maintainability, specifically in `BulletinController.java`, `BulletinServiceImpl.java`, and `RoutesModule.ts`. Note: The adjust in the `AppDefineService.ts` seems to follow the code style by adding a missing space before the method signature. The `BulletinDefine.ts` adjustment corrects the import statement for the `Fields` class. ```
Add the Apache License 2.0 header comment to the Fields.ts interface file to ensure compliance with the project's licensing requirements. This license grants users the necessary permissions to use, modify, and distribute the software, provided that they 保留此文件中的版权声明和许可声明。 ```
Adjust unit tests for the isJsonStr method in JsonUtilTest to reflect the correct expected behavior. Strings representing JSON objects and arrays should return true, aligning with the intended functionality of the method. ```
Signed-off-by: tomsun28 <tomsun28@outlook.com>
Signed-off-by: tomsun28 <tomsun28@outlook.com>
kerwin612
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Checklist
Add or update API