Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve] Improve markdown md035 #2592

Merged
merged 8 commits into from
Aug 26, 2024

Conversation

zhangshenghang
Copy link
Member

@zhangshenghang zhangshenghang commented Aug 23, 2024

What's changed?

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@github-actions github-actions bot added the doc Improvements or additions to documentation label Aug 23, 2024
@zhangshenghang zhangshenghang changed the title Improve markdown md035 [improve] Improve markdown md035 Aug 23, 2024
@Calvin979
Copy link
Contributor

Issue #2574 will be closed if you linked it on this pr. @zhangshenghang

@zhangshenghang
Copy link
Member Author

#2574

Issue #2574 will be closed if you linked it on this pr. @zhangshenghang

@Calvin979 Thank you for your reminder. Is there any way to link it without closing it

@Calvin979
Copy link
Contributor

#2574

Issue #2574 will be closed if you linked it on this pr. @zhangshenghang

@Calvin979 Thank you for your reminder. Is there any way to link it without closing it

Looks like the only way we can do is to reopen #2574 again.

@yuluo-yx
Copy link
Contributor

Instead of using fix or fixed followed by the issue number, you can use For or Of to convey the meaning.

more information: https://docs.github.com/zh/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

@Calvin979 /cc @zhangshenghang

Copy link
Contributor

@yuluo-yx yuluo-yx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zhangshenghang
Copy link
Member Author

Instead of using fix or fixed followed by the issue number, you can use For or Of to convey the meaning.

more information: https://docs.github.com/zh/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

@Calvin979 /cc @zhangshenghang

@yuluo-yx Nice , By default there is no prefix. Is it ok to just write #xxx?

@yuluo-yx
Copy link
Contributor

yuluo-yx commented Aug 25, 2024 via email

@zhangshenghang zhangshenghang merged commit 857e411 into apache:master Aug 26, 2024
4 checks passed
@zhangshenghang zhangshenghang deleted the improve-markdown-md035 branch September 3, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants