Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add push dao unit tests #2614

Merged
merged 6 commits into from
Aug 27, 2024
Merged

Add push dao unit tests #2614

merged 6 commits into from
Aug 27, 2024

Conversation

TemirlanBasitov
Copy link
Contributor

@TemirlanBasitov TemirlanBasitov commented Aug 26, 2024 •
edited
Loading

What's changed?

Added unit tests for PushMetricsDao, PushMonitorDao

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@TemirlanBasitov TemirlanBasitov mentioned this pull request Aug 26, 2024
Closed
@yuluo-yx
Copy link
Contributor

hi @TemirlanBasitov , you can run mvn checkstyle:checkstyle to check code style and fix it.

yuluo-yx
yuluo-yx approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@yuluo-yx yuluo-yx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @TemirlanBasitov

@yuluo-yx yuluo-yx merged commit 6e430bc into apache:master Aug 27, 2024
2 of 3 checks passed
@TemirlanBasitov TemirlanBasitov deleted the Add-unit-test-push-dao branch August 27, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuluo-yx yuluo-yx yuluo-yx approved these changes

Assignees
No one assigned
Labels
backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TemirlanBasitov @yuluo-yx