Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix e2e unstable #2684

Merged
merged 7 commits into from
Sep 8, 2024
Merged

fix: fix e2e unstable #2684

merged 7 commits into from
Sep 8, 2024

Conversation

LiuTianyou
Copy link
Contributor

What's changed?

  1. fix e2e unstable

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@github-actions github-actions bot added the e2e label Sep 7, 2024
collector/src/main/resources/logback-spring.xml Outdated Show resolved Hide resolved
manager/src/main/resources/logback-spring.xml Outdated Show resolved Hide resolved
Copy link
Contributor

@LinuxSuRen LinuxSuRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

api-testing has the similar way to check if the server is ready. But it cannot send a payload to the endpoint.

I'm wondering if there is an API for the health check. Return status code 200 when the server is ready to accept requests.

@LiuTianyou
Copy link
Contributor Author

api-testing has the similar way to check if the server is ready. But it cannot send a payload to the endpoint.

I'm wondering if there is an API for the health check. Return status code when the server is ready to accept requests.200

@LinuxSuRen Hello, thanks for your reply. I used the login API of hertzbeat to check whether the service is ready, but it seems that the e2e instability is not caused by inaccurate health checks.We have encountered a situation where the API that requires authentication occasionally fails in the test case. Is there a debug mode in api-testing that can output more log information, such as the URL, header, payload of the sent http request, etc. to help us troubleshoot this problem?

@LinuxSuRen
Copy link
Contributor

Sure. You can add the log output level flag, such as: atest run --level debug

@LiuTianyou
Copy link
Contributor Author

Sure. You can add the log output level flag, such as: atest run --level debug

@LinuxSuRen Thank you. got it

@yuluo-yx
Copy link
Contributor

yuluo-yx commented Sep 8, 2024

Sure. You can add the log output level flag, such as: atest run --level debug

@LinuxSuRen Thank you. got it

Current log message warn level

Copy link
Contributor

@yuluo-yx yuluo-yx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuluo-yx
Copy link
Contributor

yuluo-yx commented Sep 8, 2024

@Aias00 if no other problem, maybe we can merge it, Let's see if the e2e test after that works.

@Aias00
Copy link
Contributor

Aias00 commented Sep 8, 2024

@Aias00 if no other problem, maybe we can merge it, Let's see if the e2e test after that works.

sure

@Aias00 Aias00 merged commit 6a852b2 into apache:master Sep 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants