[bugfix](web-app): update app menu visibility on monitor creation #3072
Conversation
- Add updateLocalAppState method to update app menu visibility - Call updateLocalAppState when creating a new monitor - Move success notification and routing inside configuration update subscription
| this.configService.updateAppTemplateConfig({ hide: false }, info.monitor.app).subscribe(() => { | ||
| this.startUpSvc.loadConfigResourceViaHttp().subscribe(() => { | ||
| this.isSpinning = false; | ||
| this.notifySvc.success(this.i18nSvc.fanyi('monitor.new.success'), ''); | ||
| this.router.navigateByUrl(`/monitors?app=${info.monitor.app}`); | ||
| }); | ||
| }); | ||
| } else { | ||
| this.isSpinning = false; |
There was a problem hiding this comment.
hi, why need updateAppTemplateConfig when add a new monitor, the this.startUpSvc.loadConfigResourceViaHttp() is a very time-consuming initialization function operation
There was a problem hiding this comment.
When a user adds a new type of monitor, he should want to see it in the left navigation bar right after adding the monitor. So I think a refresh function should be added here. There seems to be a need to add a judgment here: is it the first time a certain type of monitor is added?
There was a problem hiding this comment.
I think the display of the main menu and the monitoring types added by the user should not be strictly bound.
Users can also view the added monitors by clicking on the monitoring center. The monitoring type menu in the main menu is just a shortcut. For example, in this case, it is possible that the user does not want to display the monitoring type in the main menu for simplicity. It is recommended to let the user decide whether to display this monitoring type in the main menu by editing monitoring template here instead of auto.
There was a problem hiding this comment.
I think the button to show the menu is too hidden and there is no hint of an interface that would confuse the user if used for the first time: why is there no category in the left menu? This is not user friendly for novice users, is there another way to make a good hint? I suggest discussing this on the mailing list.
There was a problem hiding this comment.
OK, 👀 we can discuss it on the mailing list or github discussions
What's changed?
Checklist
Add or update API