Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[alerter] support AlertsController unit test case (#442) #587

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

MysticalDream
Copy link
Contributor

No description provided.

Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍 LGTM!Thanks.
The pmd error can ignore due fixed by pr #585

@tomsun28 tomsun28 merged commit 7c3f681 into apache:dev Jan 17, 2023
@tomsun28
Copy link
Contributor

@all-contributors please add @MysticalDream for code, test

@allcontributors
Copy link
Contributor

@tomsun28

I've put up a pull request to add @MysticalDream! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] <Unit Test Case> com/usthe/alert/controller/AlertsController.java
2 participants