Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] add junit WarehouseWorkerPoolTest #642

Merged
merged 5 commits into from
Feb 15, 2023
Merged

[test] add junit WarehouseWorkerPoolTest #642

merged 5 commits into from
Feb 15, 2023

Conversation

TherChenYang
Copy link
Contributor

No description provided.

@tomsun28
Copy link
Contributor

Hi thanks, please use assert to instead of System.out.println

@tomsun28 tomsun28 linked an issue Feb 15, 2023 that may be closed by this pull request
[Task] <Unit Test Case> com/usthe/warehouse/WarehouseWorkerPoolTest.java #627
Closed
1 task
@TherChenYang
Copy link
Contributor Author

Hi thanks, please use assert to instead of System.out.println

Okay, I'll make the changes right away.

@TherChenYang
Copy link
Contributor Author

Hi thanks, please use assert to instead of System.out.println

I have made changes to the code, please check

tomsun28
tomsun28 approved these changes Feb 15, 2023
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!👍👍

@TherChenYang
Copy link
Contributor Author

I'm sorry for ignoring a small detail. Please complete the ci detection workflow

@tomsun28
Copy link
Contributor

@all-contributors please add @TherChenYang for code, test.
Thanks for pr. @TherChenYang can you help us to update this test case #565 https://github.com/dromara/hertzbeat/blob/master/alerter/src/test/java/com/usthe/alert/AlerterWorkerPoolTest.java

@allcontributors allcontributors bot mentioned this pull request Feb 15, 2023
Merged
@tomsun28 tomsun28 merged commit e0ce1bd into apache:master Feb 15, 2023
@allcontributors
Copy link
Contributor

@tomsun28

I've put up a pull request to add @TherChenYang! 🎉

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

tomsun28 pushed a commit that referenced this pull request Jan 16, 2024
@TherChenYang @tomsun28
[test] add junit WarehouseWorkerPoolTest (#642)
368d606 
* [test] add junit WarehouseWorkerPoolTest

* [test] refactor junit WarehouseWorkerPoolTest

* [test] solve WarehouseWorkerPoolTest detail bug

* [test] solve WarehouseWorkerPoolTest detail bug

* [test] solve incrementAndGet not execute
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
@TherChenYang
[test] add junit WarehouseWorkerPoolTest (#642)
d4ee08e 
* [test] add junit WarehouseWorkerPoolTest

* [test] refactor junit WarehouseWorkerPoolTest

* [test] solve WarehouseWorkerPoolTest detail bug

* [test] solve WarehouseWorkerPoolTest detail bug

* [test] solve incrementAndGet not execute
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
@TherChenYang
[test] add junit WarehouseWorkerPoolTest (#642)
033e8d0 
* [test] add junit WarehouseWorkerPoolTest

* [test] refactor junit WarehouseWorkerPoolTest

* [test] solve WarehouseWorkerPoolTest detail bug

* [test] solve WarehouseWorkerPoolTest detail bug

* [test] solve incrementAndGet not execute
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
@TherChenYang
[test] add junit WarehouseWorkerPoolTest (#642)
c9c0ed3 
  [test] add junit WarehouseWorkerPoolTest

  [test] refactor junit WarehouseWorkerPoolTest

  [test] solve WarehouseWorkerPoolTest detail bug

  [test] solve WarehouseWorkerPoolTest detail bug

  [test] solve incrementAndGet not execute
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
@TherChenYang
[test] add junit WarehouseWorkerPoolTest (#642)
f87af74 
  [test] add junit WarehouseWorkerPoolTest

  [test] refactor junit WarehouseWorkerPoolTest

  [test] solve WarehouseWorkerPoolTest detail bug

  [test] solve WarehouseWorkerPoolTest detail bug

  [test] solve incrementAndGet not execute
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@TherChenYang
[test] add junit WarehouseWorkerPoolTest (#642)
e317d5f 
  [test] add junit WarehouseWorkerPoolTest

  [test] refactor junit WarehouseWorkerPoolTest

  [test] solve WarehouseWorkerPoolTest detail bug

  [test] solve WarehouseWorkerPoolTest detail bug

  [test] solve incrementAndGet not execute
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@TherChenYang
[test] add junit WarehouseWorkerPoolTest (#642)
b06b189 
  [test] add junit WarehouseWorkerPoolTest

  [test] refactor junit WarehouseWorkerPoolTest

  [test] solve WarehouseWorkerPoolTest detail bug

  [test] solve WarehouseWorkerPoolTest detail bug

  [test] solve incrementAndGet not execute
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@TherChenYang
[test] add junit WarehouseWorkerPoolTest (#642)
a8ebdd4 
  [test] add junit WarehouseWorkerPoolTest

  [test] refactor junit WarehouseWorkerPoolTest

  [test] solve WarehouseWorkerPoolTest detail bug

  [test] solve WarehouseWorkerPoolTest detail bug

  [test] solve incrementAndGet not execute
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rellyrell7898 rellyrell7898 rellyrell7898 approved these changes

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
good first pull request Good for newcomers unit test case
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] <Unit Test Case> com/usthe/warehouse/WarehouseWorkerPoolTest.java
3 participants
@TherChenYang @tomsun28 @rellyrell7898