Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add verification for String app. And checkbox and key-value verification #831

Merged
merged 5 commits into from
Apr 2, 2023
Merged

Add verification for String app. And checkbox and key-value verification #831

merged 5 commits into from
Apr 2, 2023

Conversation

Carpe-Wang
Copy link
Contributor

@Carpe-Wang Carpe-Wang commented Apr 2, 2023 •
edited
Loading

What's changed?

[chore] checkbox and key-value verification
[refactor] Add verification for String app

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/codeql-analysis.yml:analyze/language:javascript. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

tomsun28
tomsun28 approved these changes Apr 2, 2023
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍👍

@tomsun28 tomsun28 merged commit 5374812 into master Apr 2, 2023
@tomsun28 tomsun28 added enhancement New feature or request good first pull request Good for newcomers labels Apr 2, 2023
@tomsun28 tomsun28 deleted the clean_todo branch April 2, 2023 13:15
tomsun28 pushed a commit that referenced this pull request Jan 16, 2024
@Carpe-Wang @tomsun28
Add verification for String app. And checkbox and key-value verificat…
d5e0bfa 
…ion (#831)

* [chore] checkbox and key-value verification

* [refactor] Add verification for String app

* [chore] checkbox and key-value verification

* [fix] UT fail

---------

Co-authored-by: Carpe-Wang <wangcarpe@126.com>
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
@Carpe-Wang
Add verification for String app. And checkbox and key-value verificat…
2317028 
…ion (#831)

* [chore] checkbox and key-value verification

* [refactor] Add verification for String app

* [chore] checkbox and key-value verification

* [fix] UT fail

---------

Co-authored-by: Carpe-Wang <wangcarpe@126.com>
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
@Carpe-Wang
Add verification for String app. And checkbox and key-value verificat…
a117f4c 
…ion (#831)

* [chore] checkbox and key-value verification

* [refactor] Add verification for String app

* [chore] checkbox and key-value verification

* [fix] UT fail

---------

Co-authored-by: Carpe-Wang <wangcarpe@126.com>
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
@Carpe-Wang
Add verification for String app. And checkbox and key-value verificat…
ba46834 
…ion (#831)

  [chore] checkbox and key-value verification

  [refactor] Add verification for String app

  [chore] checkbox and key-value verification

  [fix] UT fail

---------

Co-authored-by: Carpe-Wang <wangcarpe@126.com>
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
@Carpe-Wang @tomsun28
Add verification for String app. And checkbox and key-value verificat…
e06f08c 
…ion (#831)

  [chore] checkbox and key-value verification

  [refactor] Add verification for String app

  [chore] checkbox and key-value verification

  [fix] UT fail

---------

Co-authored-by: Carpe-Wang <wangcarpe@126.com>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@Carpe-Wang
Add verification for String app. And checkbox and key-value verificat…
a62da9c 
…ion (#831)

  [chore] checkbox and key-value verification

  [refactor] Add verification for String app

  [chore] checkbox and key-value verification

  [fix] UT fail

---------

Co-authored-by: Carpe-Wang <wangcarpe@126.com>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@Carpe-Wang
Add verification for String app. And checkbox and key-value verificat…
d1b30dc 
…ion (#831)

  [chore] checkbox and key-value verification

  [refactor] Add verification for String app

  [chore] checkbox and key-value verification

  [fix] UT fail

---------

Co-authored-by: Carpe-Wang <wangcarpe@126.com>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@Carpe-Wang
Add verification for String app. And checkbox and key-value verificat…
1798832 
…ion (#831)

  [chore] checkbox and key-value verification

  [refactor] Add verification for String app

  [chore] checkbox and key-value verification

  [fix] UT fail

---------

Co-authored-by: Carpe-Wang <wangcarpe@126.com>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@Carpe-Wang
Add verification for String app. And checkbox and key-value verificat…
4472e94 
…ion (#831)

  [chore] checkbox and key-value verification

  [refactor] Add verification for String app

  [chore] checkbox and key-value verification

  [fix] UT fail

---------

Co-authored-by: Carpe-Wang <wangcarpe@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request good first pull request Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Carpe-Wang @tomsun28