Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the @Column(length=2048) for special fields #882

Merged
merged 1 commit into from
Apr 15, 2023
Merged

Added the @Column(length=2048) for special fields #882

merged 1 commit into from
Apr 15, 2023

Conversation

dhruva1995
Copy link
Contributor

What's changed?

Issue : #870 set the special field string length when jpa auto ddl.

Changes Made:

  1. Looked for all files in the repo containing @table annotation and added @column(length=2048) where applicable.
  2. Observed common/src/main/java/org/dromara/hertzbeat/common/entity/manager/NoticeReceiver.java has many columns with @Length annotations with a max of 300, hence added the @column annotation there as well with length of 300.

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I haven't found any unit tests related to these changes, when ran mvn clean install all cases have passed.

@tomsun28 tomsun28 added enhancement New feature or request good first pull request Good for newcomers labels Apr 14, 2023
tomsun28
tomsun28 approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍thanks, LGTM!

@tomsun28
Copy link
Contributor

@all-contributors please add @dhruva1995 for code

@allcontributors allcontributors bot mentioned this pull request Apr 14, 2023
Merged
@allcontributors
Copy link
Contributor

@tomsun28

I've put up a pull request to add @dhruva1995! 🎉

@tomsun28 tomsun28 merged commit ddf6de8 into apache:master Apr 15, 2023
@dhruva1995
Copy link
Contributor Author

Thanks a lot @tomsun28, merging this PR means a lot for me; it's my very first open-source contribution.

@dhruva1995 dhruva1995 deleted the exp-clmns-lens-for-auto-ddl branch April 15, 2023 08:25
tomsun28 pushed a commit that referenced this pull request Jan 16, 2024
@dhruva1995 @tomsun28
Added the @column(length=2048) for special fields (#882)
fa8763e
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
@dhruva1995
Added the @column(length=2048) for special fields (#882)
149d266
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
@dhruva1995
Added the @column(length=2048) for special fields (#882)
4844136
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
@dhruva1995
Added the @column(length=2048) for special fields (#882)
b40c331
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
@dhruva1995 @tomsun28
Added the @column(length=2048) for special fields (#882)
a4088d6
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@dhruva1995
Added the @column(length=2048) for special fields (#882)
4d3ae31
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@dhruva1995
Added the @column(length=2048) for special fields (#882)
4a221fc
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@dhruva1995
Added the @column(length=2048) for special fields (#882)
81deaf0
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@dhruva1995
Added the @column(length=2048) for special fields (#882)
03e69dd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request good first pull request Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhruva1995 @tomsun28