Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Footer Overflow issue on the homepage #973

Merged
merged 1 commit into from
May 21, 2023
Merged

Fixed Footer Overflow issue on the homepage #973

merged 1 commit into from
May 21, 2023

Conversation

eeshaanSA
Copy link
Contributor

@eeshaanSA eeshaanSA commented May 20, 2023 •
edited
Loading

This PR closes #971

What's changed?

Changed the entire orientation of the footer.

  • added a bg that suits the site, added custom css classes and much more.

Footer Before the PR:

image
image
image

Footer after the PR is Merged :

Screencast.from.21-05-23.01.38.51.AM.IST.webm

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

@eeshaanSA
Changed footer orientation
41094c9 
Signed-off-by: eeshaanSA <eeshaans1@gmail.com>
@eeshaanSA eeshaanSA mentioned this pull request May 20, 2023
Closed
1 task
@tomsun28 tomsun28 added enhancement New feature or request good first pull request Good for newcomers labels May 21, 2023
tomsun28
tomsun28 approved these changes May 21, 2023
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!👍

@tomsun28 tomsun28 merged commit 38188d1 into apache:master May 21, 2023
tomsun28 pushed a commit that referenced this pull request Jan 16, 2024
@eeshaanSA @tomsun28
Fixed Footer Overflow issue on the homepage (#973)
f66223b 
Signed-off-by: eeshaanSA <eeshaans1@gmail.com>
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
@eeshaanSA
Fixed Footer Overflow issue on the homepage (#973)
338b268 
Signed-off-by: eeshaanSA <eeshaans1@gmail.com>
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
@eeshaanSA
Fixed Footer Overflow issue on the homepage (#973)
1dc0cc3 
Signed-off-by: eeshaanSA <eeshaans1@gmail.com>
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
@eeshaanSA
Fixed Footer Overflow issue on the homepage (#973)
b282a2c 
Signed-off-by: eeshaanSA <eeshaans1@gmail.com>
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
@eeshaanSA @tomsun28
Fixed Footer Overflow issue on the homepage (#973)
d7911b0 
Signed-off-by: eeshaanSA <eeshaans1@gmail.com>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@eeshaanSA
Fixed Footer Overflow issue on the homepage (#973)
1c6e72a 
Signed-off-by: eeshaanSA <eeshaans1@gmail.com>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@eeshaanSA
Fixed Footer Overflow issue on the homepage (#973)
3654c45 
Signed-off-by: eeshaanSA <eeshaans1@gmail.com>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@eeshaanSA
Fixed Footer Overflow issue on the homepage (#973)
29a2e89 
Signed-off-by: eeshaanSA <eeshaans1@gmail.com>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@eeshaanSA
Fixed Footer Overflow issue on the homepage (#973)
1424491 
Signed-off-by: eeshaanSA <eeshaans1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request good first pull request Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Footer Overflow on HomePage
2 participants
@eeshaanSA @tomsun28