-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HIVE-23820: [HS2] Send tableId in request for get_table_request API #2153
Conversation
7b8c529
to
1af6779
Compare
...ore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
Outdated
Show resolved
Hide resolved
6c8cb56
to
868565b
Compare
@ashish-kumar-sharma Are you planning to create one more PR to actually store the tableId in the session and to send the tableId in the request from the current session ? |
@kishendas As of now I am working on that part. I will push these changes as part of this PR only. |
086ab19
to
beda1dc
Compare
beda1dc
to
448fd76
Compare
448fd76
to
e2470b3
Compare
8c8feea
to
139ccb8
Compare
@kishendas @adesh-rao @sankarh PR complete with following logic
Please review the PR |
...ore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
Show resolved
Hide resolved
...ore-server/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java
Outdated
Show resolved
Hide resolved
139ccb8
to
444ee09
Compare
444ee09
to
8fbf34f
Compare
What changes were proposed in this pull request?
Sending table Id as part of get_table_request to verify weather table cached in HMS cache store is fresh or stale.
Why are the changes needed?
Change signature of all get_tables apis to request object model to accept tableId.
Does this PR introduce any user-facing change?
New api get_table( GetTableRequest )
How was this patch tested?
by adding and running all exisiting UTest and Qtest