-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HIVE-28211: Restore hive-exec-core jar #5209
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @simhadri-g, thanks for taking the initiative.
I would prefer before moving forward with this change to reach consensus in the community. Maybe its removal was a mistake but it did have some advantages. Please start or comment on an existing thread in the dev list and we can continue the discussion there.
Moreover, if we decide to restore the core jar it should be done under a separate JIRA ticket. HIVE-26220 is about shading problems so this is not strictly related. The shading problems will have to be resolved anyways.
Sure @zabetak , i will start or continue an existing mail thread shortly. The intention for this jira was to provide a smoother transition from the hive-exec-core to hive-exec jar for down stream projects . Thanks! |
Quality Gate passedIssues Measures |
+1 for restoring Handling hive transitive deps is always a challenge for downstream projects. forward my previous comments on google/guava#6666 (comment)
and #4888 (comment)
|
I have started a mail thread on this here: https://lists.apache.org/thread/t2vzf1mydnzsckctcvfl93srrod4w76j Thanks! |
+1 from my side, as relocating the class seems not an easy task, it requires careful tests, which may in turn causing some inconvenience and delay of upgrading to the new major release for downstream project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We have enough agreement on the ML as well, merging. |
…dappa, reviewed by Ayush Saxena, Zhihua Deng, Cheng Pan)
What changes were proposed in this pull request?
The hive-exec-core jar is used by spark, oozie, hudi and many other pojects. Removal of the hive-exec-core jar has caused the following issues.
Spark : https://lists.apache.org/list?dev@hive.apache.org:lte=1M:joda
Oozie: https://lists.apache.org/thread/yld75ltf9y8d9q3cow3xqlg0fqyj6mkg
Hudi: apache/hudi#8147
Until the we shade & relocate dependencies in hive-exec, we should restore the hive-exec core jar .
Why are the changes needed?
Does this PR introduce any user-facing change?
Is the change a dependency upgrade?
How was this patch tested?