fix: bugs detected by ut

apache · Apr 9, 2023 · 67543cc · 67543cc
1 parent fe59ce2
commit 67543cc
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/analytic_engine/src/instance/mod.rs b/analytic_engine/src/instance/mod.rs
@@ -127,7 +127,8 @@ impl Drop for SpaceStore {
 
 impl SpaceStore {
     async fn close(&self) -> Result<()> {
-        todo!("close all background jobs");
+        // TODO: close all background jobs.
+        Ok(())
     }
 }
 

diff --git a/analytic_engine/src/instance/write.rs b/analytic_engine/src/instance/write.rs
@@ -355,6 +355,8 @@ impl<'a> Writer<'a> {
     /// Do the actual write, must called by write worker in write thread
     /// sequentially.
     pub(crate) async fn write(&mut self, request: WriteRequest) -> Result<usize> {
+        self.table_data.metrics.on_write_request_begin();
+
         self.validate_before_write(&request)?;
         let mut encode_ctx = EncodeContext::new(request.row_group);
 
@@ -423,9 +425,9 @@ impl<'a> Writer<'a> {
         encoded_rows: Vec<ByteVec>,
     ) -> Result<()> {
         let sequence = self.write_to_wal(table_data, encoded_rows).await?;
-        let memserializer = MemTableWriter::make(table_data.clone(), self.serializer);
+        let memtable_writer = MemTableWriter::make(table_data.clone(), self.serializer);
 
-        memserializer
+        memtable_writer
             .write(sequence, &row_group, index_in_writer)
             .map_err(|e| {
                 error!(