Skip to content

Commit

Permalink
refactor: adopt parquet arrow async writer (#922)
Browse files Browse the repository at this point in the history
## Related Issues
Closes #

## Detailed Changes
After upgrade to parquet 38, the arrow async writer for parquet has been
supported already, so replace the custom one with it.

## Test Plan 
Existing tests.
  • Loading branch information
ShiKaiWi authored May 24, 2023
1 parent 0317948 commit ace2c1d
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 126 deletions.
4 changes: 2 additions & 2 deletions analytic_engine/src/sst/parquet/encoding.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2022 CeresDB Project Authors. Licensed under Apache-2.0.
// Copyright 2022-2023 CeresDB Project Authors. Licensed under Apache-2.0.

use std::{convert::TryFrom, mem, sync::Arc};

Expand All @@ -22,10 +22,10 @@ use common_util::{
};
use log::trace;
use parquet::{
arrow::AsyncArrowWriter,
basic::Compression,
file::{metadata::KeyValue, properties::WriterProperties},
};
use parquet_ext::async_arrow_writer::AsyncArrowWriter;
use prost::Message;
use snafu::{ensure, Backtrace, OptionExt, ResultExt, Snafu};
use tokio::io::AsyncWrite;
Expand Down
122 changes: 0 additions & 122 deletions components/parquet_ext/src/async_arrow_writer.rs

This file was deleted.

3 changes: 1 addition & 2 deletions components/parquet_ext/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
// Copyright 2022 CeresDB Project Authors. Licensed under Apache-2.0.
// Copyright 2022-2023 CeresDB Project Authors. Licensed under Apache-2.0.

pub mod async_arrow_writer;
pub mod meta_data;
pub mod prune;
pub mod reverse_reader;
Expand Down

0 comments on commit ace2c1d

Please sign in to comment.