remove default impl

analytic_engine/src/table/mod.rs

@@ -401,15 +401,15 @@ impl TableImpl {
     }
 }
 
-pub fn support_pushdown(schema: &Schema, need_dedup: bool, columns: &[String]) -> bool {
+pub fn support_pushdown(schema: &Schema, need_dedup: bool, col_names: &[String]) -> bool {
     if !need_dedup {
         return true;
     }
 
     // When table need dedup, only unique keys columns support pushdown
-    columns
+    col_names
         .iter()
-        .all(|col| schema.is_unique_column(col.as_str()))
+        .all(|col_name| schema.is_unique_column(col_name.as_str()))
 }
 
 #[async_trait]
@@ -442,10 +442,10 @@ impl Table for TableImpl {
         self.table_data.metrics.table_stats()
     }
 
-    fn support_pushdown(&self, read_schema: &Schema, columns: &[String]) -> bool {
+    fn support_pushdown(&self, read_schema: &Schema, col_names: &[String]) -> bool {
         let need_dedup = self.table_data.table_options().need_dedup();
 
-        support_pushdown(read_schema, need_dedup, columns)
+        support_pushdown(read_schema, need_dedup, col_names)
     }
 
     async fn write(&self, request: WriteRequest) -> Result<usize> {

partition_table_engine/src/partition.rs

@@ -126,10 +126,10 @@ impl Table for PartitionTableImpl {
     }
 
     // TODO: maybe we should ask remote sub table whether support pushdown
-    fn support_pushdown(&self, read_schema: &Schema, columns: &[String]) -> bool {
+    fn support_pushdown(&self, read_schema: &Schema, col_names: &[String]) -> bool {
         let need_dedup = self.table_data.options.need_dedup();
 
-        support_pushdown(read_schema, need_dedup, columns)
+        support_pushdown(read_schema, need_dedup, col_names)
     }
 
     async fn write(&self, request: WriteRequest) -> Result<usize> {

system_catalog/src/lib.rs

@@ -125,6 +125,10 @@ impl Table for SystemTableAdapter {
         TableStats::default()
     }
 
+    fn support_pushdown(&self, _read_schema: &Schema, _col_names: &[String]) -> bool {
+        false
+    }
+
     async fn write(&self, _request: WriteRequest) -> table_engine::table::Result<usize> {
         Ok(0)
     }

table_engine/src/memory.rs

@@ -118,6 +118,10 @@ impl Table for MemoryTable {
         TableStats::default()
     }
 
+    fn support_pushdown(&self, _read_schema: &Schema, _col_names: &[String]) -> bool {
+        false
+    }
+
     async fn write(&self, request: WriteRequest) -> Result<usize> {
         // TODO(yingwen) Maybe check schema?
         let mut row_groups = self.row_groups.write().unwrap();

table_engine/src/table.rs

@@ -490,9 +490,7 @@ pub trait Table: std::fmt::Debug {
     /// Whether the columns used in filter expr can be pushdown....
     /// `read_schema` is used here to avoid upper layer see different schema
     /// during one query.
-    fn support_pushdown(&self, _read_schema: &Schema, _columns: &[String]) -> bool {
-        false
-    }
+    fn support_pushdown(&self, _read_schema: &Schema, _col_names: &[String]) -> bool;
 
     /// Write to table.
     async fn write(&self, request: WriteRequest) -> Result<usize>;