feat: split operations of Cluster and Shard, and serialize operations of Shard
#1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rachelint
force-pushed
the
serialize-the-operations-in-shard
branch
6 times, most recently
from
ddf1156
to
6d10e83
Compare
ShiKaiWi
reviewed
Jul 10, 2023
Rachelint
force-pushed
the
serialize-the-operations-in-shard
branch
3 times, most recently
from
9bb8116
to
15a6899
Compare
…ns of a shard from `ShardSet` to `Shard`.
…`Shard` interface.
Rachelint
force-pushed
the
serialize-the-operations-in-shard
branch
from
15a6899
to
90a9886
Compare
ShiKaiWi
reviewed
Jul 11, 2023
Rachelint
force-pushed
the
serialize-the-operations-in-shard
branch
from
78a7de8
to
f8c38ed
Compare
Rachelint
added a commit
to Rachelint/ceresdb
that referenced
this pull request
Jul 11, 2023
…ions of `Shard` (apache#1056) ## Rationale Close apache#1053 Now, write operations for shard will be performed parallelly in ceresdb node(e.g. recover, alter tables in shard). Obviously, those operations should be performed sequentially like what about table. ## Detailed Changes + introduce `Shard` like `Table`. + make write operations for shard performing sequentially by adding a mutex. ## Test Plan Test manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Close #1053
Now, write operations for shard will be performed parallelly in ceresdb node(e.g. recover, alter tables in shard).
Obviously, those operations should be performed sequentially like what about table.
Detailed Changes
ShardlikeTable.Test Plan
Test manually.