Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: teach ceresdb to generate UnresolvedPartitionedScan for partitioned table #1148

Merged
merged 19 commits into from
Aug 17, 2023

Conversation

Rachelint
Copy link
Contributor

@Rachelint Rachelint commented Aug 13, 2023

Rationale

Part of #1112

Detailed Changes

  • Define dedicated table provider for partitioned table.
  • Generate UnresolvedPartitionedScan for partitioned table rather than ScanTable.
  • Disable UnresolvedPartitionedScan's generation in normal running, and just enable in unit test temporarily.

Test Plan

Test by new ut.

@Rachelint Rachelint force-pushed the dist-sql-query branch 5 times, most recently from f0fae6a to 9b481c3 Compare August 14, 2023 06:04
@Rachelint Rachelint marked this pull request as ready for review August 14, 2023 06:08
@Rachelint Rachelint changed the title feat: distributed sql query framework(scheduler-end) feat: teach ceresdb to generate UnresolvedPartitionedScan for partitioned table Aug 14, 2023
table_engine/src/provider.rs Outdated Show resolved Hide resolved
df_engine_extensions/src/dist_sql_query/sub_table_scan.rs Outdated Show resolved Hide resolved
query_frontend/src/provider.rs Show resolved Hide resolved
table_engine/src/provider.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rachelint Rachelint merged commit cf394fb into apache:main Aug 17, 2023
5 checks passed
Rachelint added a commit that referenced this pull request Aug 25, 2023
…xecutable(resolving process) (#1161)

## Rationale
Part of #1112 
CeresDB is able to generate the specific physical plan for partitioned
table in #1148, but it is inexecutable.
This pr introduce the `resolver` to make it executable.  

## Detailed Changes
+ Add `Resolver` to convert the `UnresolvePartitionedScan` to final
executable scan plans of sub tables.
+ Add test for the resolving process.

## Test Plan
Test by new ut.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants