-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: teach ceresdb to generate UnresolvedPartitionedScan
for partitioned table
#1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rachelint
force-pushed
the
dist-sql-query
branch
5 times, most recently
from
August 14, 2023 06:04
f0fae6a
to
9b481c3
Compare
Rachelint
changed the title
feat: distributed sql query framework(scheduler-end)
feat: teach ceresdb to generate Aug 14, 2023
UnresolvedPartitionedScan
for partitioned table
Rachelint
force-pushed
the
dist-sql-query
branch
from
August 14, 2023 12:59
78a2b5e
to
f710bda
Compare
…n found partitioned table.
Rachelint
force-pushed
the
dist-sql-query
branch
from
August 16, 2023 01:58
f710bda
to
e8c6139
Compare
jiacai2050
reviewed
Aug 16, 2023
…t to `ScanTable::output_partitioning`.
…`, `UnresolvedSubTableScan`.
… and generate `ResolvedPartitionedScan` directly.
Rachelint
force-pushed
the
dist-sql-query
branch
from
August 17, 2023 03:48
9399a20
to
528b1c1
Compare
jiacai2050
approved these changes
Aug 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Rachelint
added a commit
that referenced
this pull request
Aug 25, 2023
…xecutable(resolving process) (#1161) ## Rationale Part of #1112 CeresDB is able to generate the specific physical plan for partitioned table in #1148, but it is inexecutable. This pr introduce the `resolver` to make it executable. ## Detailed Changes + Add `Resolver` to convert the `UnresolvePartitionedScan` to final executable scan plans of sub tables. + Add test for the resolving process. ## Test Plan Test by new ut.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Part of #1112
Detailed Changes
UnresolvedPartitionedScan
for partitioned table rather thanScanTable
.UnresolvedPartitionedScan
's generation in normal running, and just enable in unit test temporarily.Test Plan
Test by new ut.