Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove license's inceptionYear and copyrightOwner #1322

Closed
wants to merge 2 commits into from

Conversation

tanruixiang
Copy link
Member

Rationale

Due to a previous pr, the year of license was changed incorrectly from 2022 to 2023, which will be corrected back to 2022 here.

Detailed Changes

change license 2023 back to 2022

Test Plan

ut.

@jiacai2050
Copy link
Contributor

I check other popular apache projects, I find there is no year in their file header, maybe we can follow this?

@tisonkun
Copy link
Member

@jiacai2050 that's what happens when we transfer to the ASF domain.

See apache/skywalking#10223 (comment) for more details.

@jiacai2050
Copy link
Contributor

Aha, it's tedious to include year in each file.

@tanruixiang Please remove year section in file header, skywalking also follow this style.

@tanruixiang
Copy link
Member Author

@tisonkun Does HawkEye's format support configurations without properties? when I remove the properties it comes up // Copyright ${inceptionYear} ${copyrightOwner}

@tanruixiang tanruixiang changed the title fix: the license year was changed incorrectly due to pr #1134 fix: remove license's inceptionYear and copyrightOwner Nov 30, 2023
@tanruixiang
Copy link
Member Author

Aha, it's tedious to include year in each file.

@tanruixiang Please remove year section in file header, skywalking also follow this style.

This should only be done once we're in the ASF, as its protocols include Licensed to the Apache Software Foundation (ASF).Do we need to remove the year's information now? @jiacai2050 @tisonkun

@tisonkun
Copy link
Member

Do we need to remove the year's information now

No.

@tanruixiang
Copy link
Member Author

No fixes will be made at this stage

@tisonkun
Copy link
Member

tisonkun commented Nov 30, 2023

Does HawkEye's format support configurations without properties

Yes. You can even use inlineHeader and configure any header template with TOML's multiline string.

Config is documented well at https://github.com/korandoru/hawkeye#config-file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants