feat: support collect statistics about the engine #1451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiacai2050
reviewed
Jan 25, 2024
| @@ -234,6 +242,63 @@ impl TableEngine for TableEngineImpl { | |||
|
|
|||
| self.close_tables_of_shard(close_requests).await | |||
| } | |||
|
|
|||
| async fn report_statistics(&self) -> Result<Option<TableEngineStats>> { | |||
There was a problem hiding this comment.
I think of one issue when using prometheus metrics to collect stats here, when a shard is transferred to another node, this metrics will remain, so you may collect those table twice.
There was a problem hiding this comment.
This case has been taken into consideration, and the solution is that a filter based on shards will be applied when reporting to meta.
There was a problem hiding this comment.
OK, a better way I can think of is to register those metrics when open shard, and unregister them when close shard.
jiacai2050
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Close #1438.
Detailed Changes
Support report statistics on shard level.
Test Plan
New unit tests is added and the CI should pass.