feat: optimize minor issues #1496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: add sst level config for benchmark
|
|
|
Would you mind also remove following TODOs, since they are stale. |
zealchen
added a commit
to zealchen/incubator-horaedb
that referenced
this pull request
Apr 9, 2024
## Rationale Related with apache#1466 ## Detailed Changes 1. Make execution_props an arguments to logical2physical. 2. Make scan_batch_size NonZeroUsize ## Test Plan Manual test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Related with #1466, fix minor issues.
Detailed Changes
Test Plan
Manual test