Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: nightly docker image name #687

Merged
merged 3 commits into from
Mar 2, 2023
Merged

fix: nightly docker image name #687

merged 3 commits into from
Mar 2, 2023

Conversation

jiacai2050
Copy link
Contributor

@jiacai2050 jiacai2050 commented Mar 2, 2023 •
edited
Loading

Which issue does this PR close?

Fix https://github.com/CeresDB/ceresdb/actions/runs/4310351950

Rationale for this change

After #684, image publish has errors

ceresdb/ceresdb-server:nightly-20230302: server message: insufficient_scope: authorization failed

What changes are included in this PR?

Are there any user-facing changes?

How does this change test

@jiacai2050 jiacai2050 changed the title fix image name fix: image name Mar 2, 2023
@jiacai2050 jiacai2050 changed the title fix: image name fix: nightly docker image name Mar 2, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2023 •
edited
Loading

Codecov Report

Merging #687 (4c4b894) into main (f0b687b) will increase coverage by 0.00%.
The diff coverage is 9.09%.

❗ Current head 4c4b894 differs from pull request most recent head 6f9bfa6. Consider uploading reports for the commit 6f9bfa6 to get more accurate results

@@           Coverage Diff           @@
##             main     #687   +/-   ##
=======================================
  Coverage   67.54%   67.55%           
=======================================
  Files         281      281           
  Lines       44302    44301    -1     
=======================================
+ Hits        29925    29926    +1     
+ Misses      14377    14375    -2
Impacted Files Coverage Δ
cluster/src/config.rs 75.00% <ø> (-2.78%) ⬇️
components/logger/src/lib.rs 27.98% <0.00%> (ø)
server/src/config.rs 38.09% <ø> (+0.88%) ⬆️
server/src/grpc/storage_service/mod.rs 45.11% <0.00%> (-0.02%) ⬇️
server/src/grpc/storage_service/write.rs 39.42% <0.00%> (+0.21%) ⬆️
server/src/http.rs 0.00% <ø> (ø)
analytic_engine/src/manifest/details.rs 95.47% <28.57%> (-0.47%) ⬇️
analytic_engine/src/instance/write_worker.rs 72.01% <0.00%> (+0.19%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jiacai2050 jiacai2050 marked this pull request as ready for review March 2, 2023 07:39
chunshao90
chunshao90 approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@chunshao90 chunshao90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunshao90 chunshao90 added this pull request to the merge queue Mar 2, 2023
Merged via the queue into apache:main with commit 1491f71 Mar 2, 2023
@jiacai2050 jiacai2050 deleted the fix-nightly branch March 2, 2023 08:40
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
@jiacai2050
fix: nightly docker image name (apache#687)
411f01d 
* fix image name

* remove meta step

* add if
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chunshao90 chunshao90 chunshao90 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jiacai2050 @codecov-commenter @chunshao90