feat: reuse logical planner in influxdb_iox #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rachelint
force-pushed
the
reuse-influxql-logical-planner
branch
from
a3271a9
to
ff85e0b
Compare
Codecov Report
@@ Coverage Diff @@
## main #730 +/- ##
==========================================
+ Coverage 68.43% 68.47% +0.03%
==========================================
Files 294 292 -2
Lines 45712 45326 -386
==========================================
- Hits 31284 31036 -248
+ Misses 14428 14290 -138
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Rachelint
force-pushed
the
reuse-influxql-logical-planner
branch
2 times, most recently
from
cb476be
to
e43065a
Compare
Rachelint
force-pushed
the
reuse-influxql-logical-planner
branch
from
e43065a
to
17d005a
Compare
Rachelint
force-pushed
the
reuse-influxql-logical-planner
branch
from
c06b490
to
ac63dbd
Compare
ShiKaiWi
reviewed
Mar 15, 2023
jiacai2050
requested changes
Mar 15, 2023
Rachelint
force-pushed
the
reuse-influxql-logical-planner
branch
2 times, most recently
from
67b58b7
to
3d13d49
Compare
Rachelint
force-pushed
the
reuse-influxql-logical-planner
branch
from
3d13d49
to
eb189a0
Compare
|
@Rachelint I'm OK with this PR. Let's wait for suggestions from @jiacai2050. |
chunshao90
pushed a commit
to chunshao90/ceresdb
that referenced
this pull request
May 15, 2023
* reust logical planner in influxdb_iox. * fix clippy. * add tests. * fix integration test. * address CR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #724
Rationale for this change
Reust logical planner in influxdb_iox.
See detail
What changes are included in this PR?
See title.
Are there any user-facing changes?
None.
How does this change test
Test by ut.