Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: timestamp column should not be auto added #787

Merged
merged 3 commits into from
Mar 29, 2023
Merged

fix: timestamp column should not be auto added #787

merged 3 commits into from
Mar 29, 2023

Conversation

chunshao90
Copy link
Contributor

@chunshao90 chunshao90 commented Mar 29, 2023

Which issue does this PR close?

Closes #779

Rationale for this change

What changes are included in this PR?

timestamp column can not be auto added.

Are there any user-facing changes?

No.

How does this change test

Add test in go sdk.

@jiacai2050 jiacai2050 changed the title fix: fix issue 779 fix: timestamp column can not be auto added Mar 29, 2023
@jiacai2050 jiacai2050 changed the title fix: timestamp column can not be auto added fix: timestamp column should not be auto added Mar 29, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2023

Codecov Report

Merging #787 (944ff53) into main (6abaaee) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

❗ Current head 944ff53 differs from pull request most recent head c7dd71a. Consider uploading reports for the commit c7dd71a to get more accurate results

@@            Coverage Diff             @@
##             main     #787      +/-   ##
==========================================
- Coverage   68.31%   68.29%   -0.03%     
==========================================
  Files         295      295              
  Lines       46695    46702       +7     
==========================================
- Hits        31901    31894       -7     
- Misses      14794    14808      +14     
Impacted Files Coverage Δ
server/src/proxy/grpc/write.rs 34.38% <0.00%> (-0.39%) ⬇️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jiacai2050 jiacai2050 added this pull request to the merge queue Mar 29, 2023
Merged via the queue into apache:main with commit 6205de9 Mar 29, 2023
jiacai2050 pushed a commit that referenced this pull request Mar 30, 2023
* fix: fix issue 779

* refactor by CR

* modify ci
chunshao90 added a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
* fix: fix issue 779

* refactor by CR

* modify ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not allow to add a not null column, name:timestamp
3 participants