Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use binary bits to determine the number of partitions #919

Merged
merged 6 commits into from
May 24, 2023
Merged

refactor: use binary bits to determine the number of partitions #919

merged 6 commits into from
May 24, 2023

Conversation

tanruixiang
Copy link
Member

@tanruixiang tanruixiang commented May 23, 2023 •
edited
Loading

Related Issues

related with #914

Detailed Changes

  • Modify the type of partitions in PartitionedMutex and PartitionedRwLock.
  • Fix the bug that multiple partitions use the same lock.

Test Plan

Unit tests under the same file.

@CLAassistant
Copy link

CLAassistant commented May 23, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@tanruixiang tanruixiang marked this pull request as ready for review May 23, 2023 08:27
jiacai2050
jiacai2050 reviewed May 23, 2023
View reviewed changes
common_util/src/partitioned_lock.rs Outdated Show resolved Hide resolved
common_util/src/partitioned_lock.rs Outdated Show resolved Hide resolved
@jiacai2050 jiacai2050 changed the title fix: Use binary bits to determine the number of partitions refactor: use binary bits to determine the number of partitions May 23, 2023
jiacai2050
jiacai2050 approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 merged commit 0317948 into apache:main May 24, 2023
@tanruixiang tanruixiang deleted the change_partitioned_lock_params branch June 13, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiacai2050 jiacai2050 jiacai2050 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tanruixiang @CLAassistant @jiacai2050