Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add log for stream read of remote engine service #961

Merged
merged 2 commits into from
Jun 1, 2023
Merged

chore: add log for stream read of remote engine service #961

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d28fe6
chore: add log for stream read of remote engine service
ShiKaiWi Jun 1, 2023
b156167
chore: refactor handle_stream_read
ShiKaiWi Jun 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 27 additions & 12 deletions server/src/grpc/remote_engine_service/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ use ceresdbproto::{
use common_types::record_batch::RecordBatch;
use common_util::{error::BoxError, time::InstantExt};
use futures::stream::{self, BoxStream, StreamExt};
use log::error;
use log::{error, info};
use proxy::instance::InstanceRef;
use query_engine::executor::Executor as QueryExecutor;
use snafu::{OptionExt, ResultExt};
Expand Down Expand Up @@ -311,23 +311,38 @@ async fn handle_stream_read(
ctx: HandlerContext,
request: ReadRequest,
) -> Result<PartitionedStreams> {
let read_request: table_engine::remote::model::ReadRequest =
request.try_into().box_err().context(ErrWithCause {
code: StatusCode::BadRequest,
msg: "fail to convert read request",
})?;

let table = find_table_by_identifier(&ctx, &read_request.table)?;

let table_engine::remote::model::ReadRequest {
table: table_ident,
read_request,
} = request.try_into().box_err().context(ErrWithCause {
code: StatusCode::BadRequest,
msg: "fail to convert read request",
})?;

let request_id = read_request.request_id;
info!(
"Handle stream read, request_id:{request_id}, table:{table_ident:?}, read_options:{:?}, read_order:{:?}, predicate:{:?} ",
read_request.opts,
read_request.order,
read_request.predicate,
);

let begin = Instant::now();
let table = find_table_by_identifier(&ctx, &table_ident)?;
let streams = table
.partitioned_read(read_request.read_request)
.partitioned_read(read_request)
.await
.box_err()
.context(ErrWithCause {
.with_context(|| ErrWithCause {
code: StatusCode::Internal,
msg: format!("fail to read table, table:{:?}", read_request.table),
msg: format!("fail to read table, table:{table_ident:?}"),
})?;

info!(
"Handle stream read success, request_id:{request_id}, table:{table_ident:?}, cost:{:?}",
begin.elapsed(),
);

Ok(streams)
}

Expand Down