feat: use get_batch to implement get_range
#971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelLeeHZ
force-pushed
the
feat-obkv-oss-get-batch
branch
from
fd4a586
to
55127ae
Compare
ShiKaiWi
reviewed
Jun 6, 2023
ShiKaiWi
reviewed
Jun 7, 2023
dust1
pushed a commit
to dust1/ceresdb
that referenced
this pull request
Aug 9, 2023
## Rationale Now the implementation of `get_range` in `ObjectStore` based on `OBKV` may cause extra IO operation, the better way is to let table_kv provide an API `get_batch` to avoid this. ## Detailed Changes * Add an API `get_batch` in table_kv * use `get_batch` implement `get_range` in `ObjectStore` based on `OBKV` ## Test Plan By unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Now the implementation of
get_rangeinObjectStorebased onOBKVmay cause extra IO operation, the better way is to let table_kv provide a apiget_batchto avoid this.Detailed Changes
get_batchin table_kvget_batchimplementget_rangeinObjectStorebased onOBKVTest Plan
By unit tests