Bug fix: allow Host headers in HTTP/2 request messages

apache · Oct 18, 2024 · 9024f46 · 9024f46
1 parent abc2f7f
commit 9024f46
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/httpcore5-h2/src/main/java/org/apache/hc/core5/http2/protocol/H2RequestConformance.java b/httpcore5-h2/src/main/java/org/apache/hc/core5/http2/protocol/H2RequestConformance.java
@@ -66,7 +66,6 @@ public H2RequestConformance() {
                 HttpHeaders.KEEP_ALIVE,
                 HttpHeaders.PROXY_CONNECTION,
                 HttpHeaders.TRANSFER_ENCODING,
-                HttpHeaders.HOST,
                 HttpHeaders.UPGRADE,
                 HttpHeaders.TE);
     }

diff --git a/httpcore5-h2/src/test/java/org/apache/hc/core5/http2/protocol/TestH2Interceptors.java b/httpcore5-h2/src/test/java/org/apache/hc/core5/http2/protocol/TestH2Interceptors.java
@@ -194,8 +194,8 @@ void testH2RequestConformanceHostHeader() {
         request.addHeader("Host", "host");
 
         final H2RequestConformance interceptor = new H2RequestConformance();
-        Assertions.assertThrows(HttpException.class, () -> interceptor.process(request, null, context),
-                "Header 'Host: host' is illegal for HTTP/2 messages");
+        Assertions.assertDoesNotThrow(() -> interceptor.process(request, null, context),
+                "Header 'Host: host' is permissible for HTTP/2 messages");
     }
 
     @Test