Mention HttpStatus and StatusCode in JavaDoc in more places #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ok2c
pushed a commit
that referenced
this pull request
Jan 25, 2024
* Add JavaDoc @see cross-references between HttpStatus and StatusClass * Mention HttpStatus in JavaDoc of HttpResponse.getCode
|
@unkarjedy Cherry-picked to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was originally searching for a way to test that
HttpStatuscode was "successful".I didn't want to create a utility in my code base which checks
200 <= code && code < 300, because it's a too frequent pattern.I found
org.apache.hc.core5.http.message.StatusLine.StatusClass#frombut I spent a couple of minutes for that.It would be much easier if it was mentioned in the
HttpStatusJavaDoc, because those two entities are closely interconnected.