Skip to content

Commit

Permalink
fix comments
Browse files Browse the repository at this point in the history
  • Loading branch information
gengxiaoyu committed May 16, 2022
1 parent 1310d3f commit 96bf68f
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
import java.util.Properties;

/**
* Configurations used by the HUDI Metadata Table.
* Configurations used by the HUDI Metastore.
*/
@Immutable
@ConfigClassProperty(name = "Metastore Configs",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,8 @@
public class FileSystemViewManager {
private static final Logger LOG = LogManager.getLogger(FileSystemViewManager.class);

private static final String HOODIE_METASTORE_FILE_SYSTEM_VIEW_CLASS = "org.apache.hudi.common.table.view.HoodieMetastoreFileSystemView";

private final SerializableConfiguration conf;
// The View Storage config used to store file-system views
private final FileSystemViewStorageConfig viewStorageConfig;
Expand Down Expand Up @@ -168,7 +170,7 @@ private static HoodieTableFileSystemView createInMemoryFileSystemView(HoodieMeta
metadataSupplier.get());
}
if (metaClient.getMetastoreConfig().enableMetastore()) {
return (HoodieTableFileSystemView) ReflectionUtils.loadClass("org.apache.hudi.common.table.view.HoodieMetastoreFileSystemView",
return (HoodieTableFileSystemView) ReflectionUtils.loadClass(HOODIE_METASTORE_FILE_SYSTEM_VIEW_CLASS,
new Class<?>[] {HoodieTableMetaClient.class, HoodieTimeline.class, HoodieMetastoreConfig.class},
metaClient, metaClient.getActiveTimeline().getCommitsTimeline().filterCompletedInstants(), metaClient.getMetastoreConfig());
}
Expand All @@ -192,7 +194,7 @@ public static HoodieTableFileSystemView createInMemoryFileSystemViewWithTimeline
return new HoodieMetadataFileSystemView(engineContext, metaClient, timeline, metadataConfig);
}
if (metaClient.getMetastoreConfig().enableMetastore()) {
return (HoodieTableFileSystemView) ReflectionUtils.loadClass("org.apache.hudi.common.table.view.HoodieMetastoreFileSystemView",
return (HoodieTableFileSystemView) ReflectionUtils.loadClass(HOODIE_METASTORE_FILE_SYSTEM_VIEW_CLASS,
new Class<?>[] {HoodieTableMetaClient.class, HoodieTimeline.class, HoodieMetadataConfig.class},
metaClient, metaClient.getActiveTimeline().getCommitsTimeline().filterCompletedInstants(), metaClient.getMetastoreConfig());
}
Expand Down

0 comments on commit 96bf68f

Please sign in to comment.