[HUDI-3633] Allow non-string values to be set in TypedProperties

[codope]

What is the purpose of the pull request

TypedProperties invokes Properties#stringPropertynames() which expects that key and values should be strings. It causes keys with non-string values to be not found. See #5026 . This PR fixes that behavior.

Brief change log

(for example:)

• Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

• Added integration tests for end-to-end.
• Added HoodieClientWriteTest to verify the change.
• Manually verified the change by running a job locally.

Committer checklist

• Has a corresponding JIRA in PR title & commit

• Commit message is descriptive of the change

• CI is green

• Necessary doc changes done or have another open PR

• For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

[wangxianghu]

hi @codope This patch solved issue #5026
but if the user use

typedProperties.put("key", 123);

the kv still lost

may be we should override java.util.Properties#getProperty(java.lang.String) to ignore the string type check
the getProperty method in java.util.Properties:

    public String getProperty(String key) {
        Object oval = super.get(key);
        String sval = (oval instanceof String) ? (String)oval : null;
        return ((sval == null) && (defaults != null)) ? defaults.getProperty(key) : sval;
    }

[codope]

may be we should override java.util.Properties#getProperty(java.lang.String) to ignore the string type check
the getProperty method in java.util.Properties

We could do that. I wonder why was this instanceof String check added?

[wangxianghu]

may be we should override java.util.Properties#getProperty(java.lang.String) to ignore the string type check
the getProperty method in java.util.Properties

We could do that. I wonder why was this instanceof String check added?

The return type is String, use instanceof String check may avoid class cast exception

[codope]

Still the TypedProperties constructor takes a Properties argument and calling defaults.getProperty won't have the desired effect.

[wangxianghu]

LGTM

[wangxianghu]

@hudi-bot run azure

[hudi-bot]

CI report:

• 1e63407 Azure: FAILURE Azure: SUCCESS

Bot commands

@hudi-bot supports the following commands:

• @hudi-bot run azure re-run the last Azure build