[HUDI-4052] Move HoodieMetricsCloudWatchConfig to hudi-client-common #5518
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
Currently, HoodieMetricsCloudWatchConfig is part of hudi-aws module, while HoodieMetricConfig is part of hudi-client-common. The builder of HoodieMetricConfig uses HoodieMetricsCloudWatchConfig. When we want to use hudi write client in other engines (presto/trino), we need to include hudi-aws module because HoodieMetricsConfig initialization falls in that path. But, this bloats the presto/trino bundle, which we want to keep as light as possible.
This PR decouples the two. Let all metric configs be in client-common (e.g. prometheus and datadog configs are already there). This way we can exclude hudi-aws from the bundles.
Brief change log
(for example:)
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.