Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUDI-4052] Move HoodieMetricsCloudWatchConfig to hudi-client-common #5518

Closed
wants to merge 1 commit into from

Conversation

codope
Copy link
Member

@codope codope commented May 6, 2022

What is the purpose of the pull request

Currently, HoodieMetricsCloudWatchConfig is part of hudi-aws module, while HoodieMetricConfig is part of hudi-client-common. The builder of HoodieMetricConfig uses HoodieMetricsCloudWatchConfig. When we want to use hudi write client in other engines (presto/trino), we need to include hudi-aws module because HoodieMetricsConfig initialization falls in that path. But, this bloats the presto/trino bundle, which we want to keep as light as possible.

This PR decouples the two. Let all metric configs be in client-common (e.g. prometheus and datadog configs are already there). This way we can exclude hudi-aws from the bundles.

Brief change log

(for example:)

  • Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end.
  • Added HoodieClientWriteTest to verify the change.
  • Manually verified the change by running a job locally.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@hudi-bot
Copy link

hudi-bot commented May 6, 2022

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@codope
Copy link
Member Author

codope commented May 24, 2022

Closing it in favor of #5666

@codope codope closed this May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants