Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUDI-4311] Fix Flink lose data on some rollback scene #5950

Merged
merged 6 commits into from
Jun 27, 2022
Merged

[HUDI-4311] Fix Flink lose data on some rollback scene #5950

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d25cf6e
fix lose data on some rollback scene
wxplovecc Jun 23, 2022
5f81f39
fix lose data on some rollback scene
wxplovecc Jun 24, 2022
237c256
fix lose data on some rollback scene
wxplovecc Jun 24, 2022
6099161
do not abort instant when some write task was failed
wxplovecc Jun 24, 2022
1b1334c
do not abort instant when some write task was failed
wxplovecc Jun 24, 2022
3e8a36c
rollback task failed scene
wxplovecc Jun 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ...asource/hudi-flink/src/main/java/org/apache/hudi/sink/StreamWriteOperatorCoordinator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import java.io.IOException;
import java.io.Serializable;
import java.util.Arrays;
import java.util.Collection;
Expand Down Expand Up @@ -305,6 +306,13 @@ public void subtaskFailed(int i, @Nullable Throwable throwable) {
// reset the event
this.eventBuffer[i] = null;
LOG.warn("Reset the event for task [" + i + "]", throwable);
if (Arrays.stream(this.eventBuffer).allMatch(event -> event == null)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we roll back this change now, not sure if it is right.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In StreamWriteOperatorCoordinator#notifyCheckpointAborted,
we can add another check condition:
checkpointId == this.checkpointId && !WriteMetadataEvent.BOOTSTRAP_INSTANT.equals(this.instant)
to make sure not abort the instant during first time startup for rollback

try {
this.ckpMetadata.bootstrap(this.metaClient);
} catch (IOException e) {
throw new HoodieException("Bootstrap ckpMetadata exception", e);
}
}
}

@Override
Expand Down
6 changes: 3 additions & 3 deletions hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/meta/CkpMetadata.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,6 @@ public void close() {
public void bootstrap(HoodieTableMetaClient metaClient) throws IOException {
fs.delete(path, true);
fs.mkdirs(path);
metaClient.getActiveTimeline().getCommitsTimeline().filterPendingExcludingCompaction()
.lastInstant().ifPresent(instant -> startInstant(instant.getTimestamp()));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we remove the logic of start last pending instant, how can we recommit the inflight commit? cc @wxplovecc @danny0405

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would rollback it first before starting a new one.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danny0405 When flink checkpoint complete but hudi commit failed, we need recommit the commit, rollback the inflight commit will lose data, any new logic to guard this case?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leesf shall we consider this related PR？#5913
It will re-send pending instants to ckp_meta when bootstrap, and introduce a mechanism of CANCELLED state to eliminate rollbacked instants.
Thus last successful instant will be kept when recovering for recommit

}

public void startInstant(String instant) {
Expand Down Expand Up @@ -154,7 +152,9 @@ public void commitInstant(String instant) {
public void abortInstant(String instant) {
Path path = fullPath(CkpMessage.getFileName(instant, CkpMessage.State.ABORTED));
try {
fs.createNewFile(path);
if (fs.exists(fullPath(CkpMessage.getFileName(instant, CkpMessage.State.INFLIGHT)))) {
fs.createNewFile(path);
}
} catch (IOException e) {
throw new HoodieException("Exception while adding checkpoint abort metadata for instant: " + instant);
}
Expand Down