Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] Fix typo in HoodieArchivalConfig #6542

Merged
merged 1 commit into from
Aug 31, 2022
Merged

[MINOR] Fix typo in HoodieArchivalConfig #6542

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions ...-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieArchivalConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,9 @@ public class HoodieArchivalConfig extends HoodieConfig {
public static final ConfigProperty<String> MAX_COMMITS_TO_KEEP = ConfigProperty
.key("hoodie.keep.max.commits")
.defaultValue("30")
.withDocumentation("Archiving service moves older entries from timeline into an archived log after each write, to "
.withDocumentation("Archiving service moves older entries from timeline into an archived log after each write, to"
+ " keep the metadata overhead constant, even as the table size grows."
+ "This config controls the maximum number of instants to retain in the active timeline. ");
+ " This config controls the maximum number of instants to retain in the active timeline. ");

public static final ConfigProperty<Integer> DELETE_ARCHIVED_INSTANT_PARALLELISM_VALUE = ConfigProperty
.key("hoodie.archive.delete.parallelism")
Expand All @@ -69,7 +69,7 @@ public class HoodieArchivalConfig extends HoodieConfig {
.key("hoodie.keep.min.commits")
.defaultValue("20")
.withDocumentation("Similar to " + MAX_COMMITS_TO_KEEP.key() + ", but controls the minimum number of"
+ "instants to retain in the active timeline.");
+ " instants to retain in the active timeline.");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nsivabalan This generated ofinstants before.


public static final ConfigProperty<String> COMMITS_ARCHIVAL_BATCH_SIZE = ConfigProperty
.key("hoodie.commits.archival.batch")
Expand Down Expand Up @@ -97,8 +97,8 @@ public class HoodieArchivalConfig extends HoodieConfig {
.key("hoodie.archive.beyond.savepoint")
.defaultValue(false)
.sinceVersion("0.12.0")
.withDocumentation("If enabled, archival will proceed beyond savepoint, skipping savepoint commits. "
+ "If disabled, archival will stop at the earliest savepoint commit.");
.withDocumentation("If enabled, archival will proceed beyond savepoint, skipping savepoint commits."
+ " If disabled, archival will stop at the earliest savepoint commit.");

/**
* @deprecated Use {@link #MAX_COMMITS_TO_KEEP} and its methods instead
Expand Down