Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUDI-5233] Fix bug when InternalSchemaUtils.collectTypeChangedCols returns all columns #7228

Merged
merged 1 commit into from
Nov 18, 2022

Conversation

trushev
Copy link
Contributor

@trushev trushev commented Nov 17, 2022

Change Logs

We need to override equals because the check intType1 == intType2 can return false.
Despite the fact that most subclasses of Type look like singleton with static field INSTANCE, they can still be created by deserializer. It means that the check below always returns true InternalSchemaUtils.java:

if (!schema.findType(f).equals(oldSchema.findType(f))) {

Impact

InternalSchemaUtils.collectTypeChangedCols returns only changed columns

Risk level

Low

Documentation Update

None

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@hudi-bot
Copy link

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@xiarixiaoyao xiarixiaoyao merged commit e4e2883 into apache:master Nov 18, 2022
satishkotha pushed a commit to satishkotha/incubator-hudi that referenced this pull request Dec 12, 2022
alexeykudinkin pushed a commit to onehouseinc/hudi that referenced this pull request Dec 14, 2022
alexeykudinkin pushed a commit to onehouseinc/hudi that referenced this pull request Dec 14, 2022
alexeykudinkin pushed a commit to onehouseinc/hudi that referenced this pull request Dec 14, 2022
alexeykudinkin pushed a commit to onehouseinc/hudi that referenced this pull request Dec 14, 2022
fengjian428 pushed a commit to fengjian428/hudi that referenced this pull request Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants