-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HUDI-5251] Split GitHub actions CI by spark and flink #7265
[HUDI-5251] Split GitHub actions CI by spark and flink #7265
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, i can not validate locally because of the compile error on MacPro m1, but the direction is correct.
@danny0405 to land this pr, there is a bigger implication: we have to restructure the way CI is built and run. We need to separate flink and spark build process as spark 2.4 and 3.1 uses avro 1.8.2 which conflicts with flink profiles. The integration test is trickier where all bundles are put together. We can only do it when using spark 3.2 profile (avro 1.10.2) to fit with flink profiles. I have to get back to this later. but we'll still need to resolve this for 0.12.2 |
@xushiyan : do we need to target this for 0.12.2 ? |
yes this issue is a show-stopper for flink bundle |
e33b84a
to
eb921af
Compare
@nsivabalan @danny0405 overwriting avro.version in flink profiles causes conflicts in how we setup CI today. I've kept the old way of overwriting version but make flink-bundle built differently for release. pls review #7419 |
This reverts commit 36dea30.
826bedc
to
21cb894
Compare
Change Logs
flink bundle use 1.10.0 avro version, but hudi common modes were generated during build process controlled by
avro.version
property, which is not overwritten in flink profiles. This would resulted in generated models being incompatible with included avro lib in flink-bundle.This change separate out spark and flink build process in GH actions CI so that spark and flink profiles do not interfere each other. For example, spark 3.3 profile uses avro 1.11 which should not be used for flink bundle.
Related issues
Follow up
We need to make sure release artifacts not to be impacted by the profile settings.
Impact
Build process for flink bundles has to be separated out from other bundles. Dev and release processes should be updated accordingly.
Risk level
low
Documentation Update
Contributor's checklist