Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUDI-5251] Split GitHub actions CI by spark and flink #7265

Merged
merged 8 commits into from
Dec 15, 2022

Conversation

xushiyan
Copy link
Member

@xushiyan xushiyan commented Nov 21, 2022

Change Logs

flink bundle use 1.10.0 avro version, but hudi common modes were generated during build process controlled by avro.version property, which is not overwritten in flink profiles. This would resulted in generated models being incompatible with included avro lib in flink-bundle.

This change separate out spark and flink build process in GH actions CI so that spark and flink profiles do not interfere each other. For example, spark 3.3 profile uses avro 1.11 which should not be used for flink bundle.

Related issues

Follow up

We need to make sure release artifacts not to be impacted by the profile settings.

Impact

Build process for flink bundles has to be separated out from other bundles. Dev and release processes should be updated accordingly.

Risk level

low

Documentation Update

  • build instructions to be updated
  • release process to be updated

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@xushiyan xushiyan added dependencies Pull requests that update a dependency file priority:blocker flink Issues related to flink labels Nov 21, 2022
Copy link
Contributor

@danny0405 danny0405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, i can not validate locally because of the compile error on MacPro m1, but the direction is correct.

@xushiyan
Copy link
Member Author

@danny0405 to land this pr, there is a bigger implication: we have to restructure the way CI is built and run. We need to separate flink and spark build process as spark 2.4 and 3.1 uses avro 1.8.2 which conflicts with flink profiles. The integration test is trickier where all bundles are put together. We can only do it when using spark 3.2 profile (avro 1.10.2) to fit with flink profiles. I have to get back to this later. but we'll still need to resolve this for 0.12.2

@nsivabalan
Copy link
Contributor

@xushiyan : do we need to target this for 0.12.2 ?

@xushiyan
Copy link
Member Author

xushiyan commented Dec 6, 2022

@xushiyan : do we need to target this for 0.12.2 ?

yes this issue is a show-stopper for flink bundle

@xushiyan xushiyan added the release-0.12.2 Patches targetted for 0.12.2 label Dec 9, 2022
@xushiyan xushiyan self-assigned this Dec 9, 2022
@xushiyan xushiyan force-pushed the HUDI-5251-flink-avro-version branch from e33b84a to eb921af Compare December 9, 2022 11:40
@xushiyan
Copy link
Member Author

xushiyan commented Dec 9, 2022

@nsivabalan @danny0405 overwriting avro.version in flink profiles causes conflicts in how we setup CI today. I've kept the old way of overwriting version but make flink-bundle built differently for release. pls review #7419

@xushiyan xushiyan force-pushed the HUDI-5251-flink-avro-version branch from 826bedc to 21cb894 Compare December 14, 2022 16:24
@xushiyan xushiyan changed the title [HUDI-5251] Fix flink avro version conflict [HUDI-5251] Split GitHub actions CI by spark and flink Dec 14, 2022
@hudi-bot
Copy link

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@alexeykudinkin alexeykudinkin removed the release-0.12.2 Patches targetted for 0.12.2 label Dec 15, 2022
@xushiyan xushiyan merged commit 972408b into apache:master Dec 15, 2022
@xushiyan xushiyan deleted the HUDI-5251-flink-avro-version branch December 15, 2022 13:52
fengjian428 pushed a commit to fengjian428/hudi that referenced this pull request Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file flink Issues related to flink priority:blocker
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants