[HUDI-5234] Streaming read skip clustering #7296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
danny0405
commented
Nov 24, 2022
| public static void writeDataAsInsert( | ||
| List<RowData> dataBuffer, | ||
| Configuration conf) throws Exception { | ||
| InsertFunctionWrapper<RowData> funcWrapper = new InsertFunctionWrapper<>( |
There was a problem hiding this comment.
TODO: would refactor the code with writer wrapper.
XuQianJin-Stars
approved these changes
Nov 24, 2022
SteNicholas
reviewed
Nov 24, 2022
| .booleanType() | ||
| .defaultValue(false) | ||
| .withDescription("Whether to skip clustering instants for streaming read,\n" | ||
| + "to avoid reading duplicates"); |
There was a problem hiding this comment.
Could you add the cases which cause reading duplicates in the description?
There was a problem hiding this comment.
Yeah, that's needed, can you add more cases for clustering here ? You can add UTs in TestInputFormat.
There was a problem hiding this comment.
@danny0405, ok. I will do adding the UTs.
satishkotha
pushed a commit
to satishkotha/incubator-hudi
that referenced
this pull request
Dec 12, 2022
Co-authored-by: zhuanshenbsj1 <zhuanshen_bsj@163.com>
fengjian428
pushed a commit
to fengjian428/hudi
that referenced
this pull request
Apr 5, 2023
Co-authored-by: zhuanshenbsj1 <zhuanshen_bsj@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Supports skipping the clustering commits while reading. This can make the streaming read under clustering more efficient because the clustering files are all rewritten with the original records.
Impact
No
Risk level (write none, low medium or high below)
none
Documentation Update
Should update the doc whith this new option
read.streaming.skip_clustering.Contributor's checklist