[HUDI-5277] Close HoodieWriteClient before exiting RunClusteringProcedure #7300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leesf
reviewed
Nov 24, 2022
| } | ||
| } | ||
| } finally if (client != null) client.close() |
There was a problem hiding this comment.
finally {
if (client != null) {
client.close()
}
}
stream2000
changed the title
stream2000
force-pushed
the
fix_run_clustering_cannot_exit_in_sparksql
branch
from
49746e2 to
5339b10
Compare
leesf
reviewed
Nov 25, 2022
| @@ -105,35 +105,41 @@ class RunClusteringProcedure extends BaseProcedure | |||
| logInfo(s"Pending clustering instants: ${pendingClustering.mkString(",")}") | |||
|
|
|||
| val client = HoodieCLIUtils.createHoodieClientFromPath(sparkSession, basePath, conf) | |||
There was a problem hiding this comment.
var client = null out of try block and put client = HoodieCLIUtils.createHoodieClientFromPath(sparkSession, basePath, conf) into try block.
stream2000
force-pushed
the
fix_run_clustering_cannot_exit_in_sparksql
branch
from
5339b10 to
4b44ca1
Compare
leesf
approved these changes
Nov 25, 2022
satishkotha
pushed a commit
to satishkotha/incubator-hudi
that referenced
this pull request
Dec 12, 2022
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Dec 14, 2022
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Dec 14, 2022
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Dec 14, 2022
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Dec 14, 2022
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Dec 14, 2022
fengjian428
pushed a commit
to fengjian428/hudi
that referenced
this pull request
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Close HoodieWriteClient before exiting RunClusteringProcedure to close the timeline server, so that the whole sparksql program can exit correctly.
Impact
RunClusteringProcedure can exit correctly
Risk level (write none, low medium or high below)
None
Documentation Update
Nothing
Contributor's checklist