Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUDI-5291] Fixing NPE in MOR column stats accounting #7349

Merged
merged 2 commits into from
Dec 8, 2022

Conversation

alexeykudinkin
Copy link
Contributor

Change Logs

This is addressing NPE while handling column stats w/in the HoodieAppendHandle

Impact

Low

Risk level (write none, low medium or high below)

Low

Documentation Update

N/A

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@alexeykudinkin alexeykudinkin requested a review from codope December 1, 2022 03:14
Copy link
Member

@codope codope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for covering the scenario. I don't see any change in source code (only test has changed). So, is it alrady handled?

Copy link
Member

@codope codope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for taking care of this issue. We can land once the CI is green.

@codope codope added priority:critical production down; pipelines stalled; Need help asap. index metadata metadata table labels Dec 1, 2022
@codope codope self-assigned this Dec 1, 2022
@apache apache deleted a comment from hudi-bot Dec 5, 2022
@hudi-bot
Copy link

hudi-bot commented Dec 5, 2022

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@nsivabalan nsivabalan added priority:blocker release-0.12.2 Patches targetted for 0.12.2 priority:critical production down; pipelines stalled; Need help asap. and removed priority:critical production down; pipelines stalled; Need help asap. priority:blocker labels Dec 5, 2022
@codope
Copy link
Member

codope commented Dec 7, 2022

testMetadataColumnStatsIndex is flaky in my local setup as well. Once in a while, valueCount does not match. @alexeykudinkin Can you please look into the failure?

@alexeykudinkin
Copy link
Contributor Author

@codope yeah, it seems like it flakes every once and a while but it occurs very infrequently locally for me. Are you able to repro it consistently?

@alexeykudinkin
Copy link
Contributor Author

@codope i'm going to merge this one and follow-up on flakiness separately. My hunch is that it might be related to test isolation not being watertight.

https://issues.apache.org/jira/browse/HUDI-5354

CI is green:

Screenshot 2022-12-08 at 2 03 50 PM

https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=13428&view=results

@alexeykudinkin alexeykudinkin merged commit 2da69d3 into apache:master Dec 8, 2022
@codope
Copy link
Member

codope commented Dec 12, 2022

yeah, it seems like it flakes every once and a while but it occurs very infrequently locally for me. Are you able to repro it consistently?

No, I can't reproduce consistently. But, every 1/20 times it does fail. I will look into this if you haven't already started. I would like to add whenever it fails it's for MOR table.

https://issues.apache.org/jira/browse/HUDI-5371

nsivabalan pushed a commit that referenced this pull request Dec 13, 2022
This is addressing NPE while handling column stats w/in the HoodieAppendHandle
alexeykudinkin added a commit to onehouseinc/hudi that referenced this pull request Dec 14, 2022
This is addressing NPE while handling column stats w/in the HoodieAppendHandle
alexeykudinkin added a commit to onehouseinc/hudi that referenced this pull request Dec 14, 2022
This is addressing NPE while handling column stats w/in the HoodieAppendHandle
alexeykudinkin added a commit to onehouseinc/hudi that referenced this pull request Dec 14, 2022
This is addressing NPE while handling column stats w/in the HoodieAppendHandle
alexeykudinkin added a commit to onehouseinc/hudi that referenced this pull request Dec 14, 2022
This is addressing NPE while handling column stats w/in the HoodieAppendHandle
alexeykudinkin added a commit to onehouseinc/hudi that referenced this pull request Dec 14, 2022
This is addressing NPE while handling column stats w/in the HoodieAppendHandle
alexeykudinkin added a commit to onehouseinc/hudi that referenced this pull request Dec 14, 2022
This is addressing NPE while handling column stats w/in the HoodieAppendHandle
alexeykudinkin added a commit to onehouseinc/hudi that referenced this pull request Dec 14, 2022
This is addressing NPE while handling column stats w/in the HoodieAppendHandle
alexeykudinkin added a commit that referenced this pull request Dec 14, 2022
This is addressing NPE while handling column stats w/in the HoodieAppendHandle
fengjian428 pushed a commit to fengjian428/hudi that referenced this pull request Apr 5, 2023
This is addressing NPE while handling column stats w/in the HoodieAppendHandle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
index metadata metadata table priority:critical production down; pipelines stalled; Need help asap. release-0.12.2 Patches targetted for 0.12.2
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants