-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HUDI-5291] Fixing NPE in MOR column stats accounting #7349
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for covering the scenario. I don't see any change in source code (only test has changed). So, is it alrady handled?
df0fcbf
to
6a9050f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for taking care of this issue. We can land once the CI is green.
6a9050f
to
89a6daa
Compare
89a6daa
to
cdbda3c
Compare
|
@codope yeah, it seems like it flakes every once and a while but it occurs very infrequently locally for me. Are you able to repro it consistently? |
@codope i'm going to merge this one and follow-up on flakiness separately. My hunch is that it might be related to test isolation not being watertight. https://issues.apache.org/jira/browse/HUDI-5354 CI is green: https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=13428&view=results |
No, I can't reproduce consistently. But, every 1/20 times it does fail. I will look into this if you haven't already started. I would like to add whenever it fails it's for MOR table. |
This is addressing NPE while handling column stats w/in the HoodieAppendHandle
This is addressing NPE while handling column stats w/in the HoodieAppendHandle
This is addressing NPE while handling column stats w/in the HoodieAppendHandle
This is addressing NPE while handling column stats w/in the HoodieAppendHandle
This is addressing NPE while handling column stats w/in the HoodieAppendHandle
This is addressing NPE while handling column stats w/in the HoodieAppendHandle
This is addressing NPE while handling column stats w/in the HoodieAppendHandle
This is addressing NPE while handling column stats w/in the HoodieAppendHandle
Change Logs
This is addressing NPE while handling column stats w/in the
HoodieAppendHandle
Impact
Low
Risk level (write none, low medium or high below)
Low
Documentation Update
N/A
Contributor's checklist