Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUDI-5822] Fix FileId not found exception when FileId is passed to HoodieMergeHa... #8263

Merged
merged 2 commits into from
Mar 22, 2023

Conversation

voonhous
Copy link
Member

@voonhous voonhous commented Mar 22, 2023

...ndle

Applying the fix from #5185 will fix write issues for MOR tables, but will cause write issues for COW tables.

More information on how to reproduce the COW error in this jira issue:
https://issues.apache.org/jira/browse/HUDI-5822

This addresses the issue raised here: #5782

NOTE

HEADSUP for future cherrypickers, for this fix to work, HUDI-5862 has to be picked first.

i.e. HUDI-5822 relies on HUDI-5862

Change Logs

  1. Complement the change of getLatestFileSlices -> getAllFileGroups in [HUDI-3758] Fix duplicate fileId error in MOR table type with flink bucket hash Index  #5185

Impact

  1. Allow jobs to recover properly
  2. Ensure that the correct fileSlices are being read

Risk level (write none, low medium or high below)

None

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@voonhous
Copy link
Member Author

@danny0405
Re-created the PR as #7997 is unable to trigger CI.

@hudi-bot
Copy link

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

Copy link
Contributor

@danny0405 danny0405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@danny0405 danny0405 merged commit a75da8c into apache:master Mar 22, 2023
@voonhous
Copy link
Member Author

HEADSUP for future cherrypickers, for this fix to work, HUDI-5862 has to be picked first.

i.e. HUDI-5822 relies on HUDI-5862

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants