[HUDI-6401] should not throw exception when create marker file for lo… #9003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danny0405
reviewed
Jun 18, 2023
| @@ -296,7 +296,7 @@ protected class AppendLogWriteCallback implements HoodieLogFileWriteCallback { | |||
| public boolean preLogFileOpen(HoodieLogFile logFileToAppend) { | |||
| // we use create rather than createIfNotExists because create method can trigger marker-based early conflict detection. | |||
| WriteMarkers writeMarkers = WriteMarkersFactory.get(config.getMarkersType(), hoodieTable, instantTime); | |||
| return writeMarkers.create(partitionPath, logFileToAppend.getFileName(), IOType.APPEND, | |||
| return writeMarkers.createIfNotExists(partitionPath, logFileToAppend.getFileName(), IOType.APPEND, | |||
There was a problem hiding this comment.
also needs to fix the comment.
There was a problem hiding this comment.
removed incorrect comment.
danny0405
reviewed
Jun 18, 2023
| public Option<Path> createIfNotExists(String partitionPath, String fileName, IOType type, HoodieWriteConfig writeConfig, | ||
| String fileId, HoodieActiveTimeline activeTimeline) { | ||
| if (writeConfig.getWriteConcurrencyMode().supportsOptimisticConcurrencyControl() | ||
| && writeConfig.isEarlyConflictDetectionEnable()) { |
There was a problem hiding this comment.
can we change it to
&& writeConfig.getWriteConcurrencyMode().supportsOptimisticConcurrencyControl()
which is more efficient.
There was a problem hiding this comment.
Swap them in new commit.
danny0405
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Change method to create marker file for log file from create to create if not exists.
Impact
For spark jobs has task failed or speculation enabled, will throw exception when write log
Risk level (write none, low medium or high below)
low
Documentation Update
No need to update
Contributor's checklist