How to get rid of the warning

[djouallah]

Question

using this code with pyiceberg 0.8

tbl = db+"."+"calendar"
if not catalog.table_exists(tbl):
  df=duckdb.sql(""" SELECT cast(unnest(generate_series(cast ('2018-04-01' as date), cast('2024-12-31' as date), interval 1 day)) as date) as date,
            EXTRACT(year from date) as year,
            EXTRACT(month from date) as month
            """).arrow()
  catalog.create_table_if_not_exists(tbl,schema=df.schema)
  catalog.load_table(tbl).overwrite(df)
  print('calendar created')
else:
    print("table exist already")

I am getting this warning, how I can remove it

/usr/local/lib/python3.10/dist-packages/pyiceberg/utils/deprecated.py:54: DeprecationWarning: Deprecated in 0.8.0, will be removed in 0.9.0. Table.identifier property is deprecated. Please use Table.name() function instead.
  _deprecation_warning(deprecation_notice(deprecated_in, removed_in, help_message))
/usr/local/lib/python3.10/dist-packages/pyiceberg/utils/deprecated.py:54: DeprecationWarning: Deprecated in 0.8.0, will be removed in 0.9.0. Support for parsing catalog level identifier in Catalog identifiers is deprecated. Please refer to the table using only its namespace and its table name.
  _deprecation_warning(deprecation_notice(deprecated_in, removed_in, help_message))
calendar created

[kevinjqliu]

Thanks for reporting this! This is a bug where the warning is emitted when the catalog identifier is not used.

[kevinjqliu]

Possibly related to #1318, but i'll double check

[Fokko]

Looping in @sungwy here, did you mean to return self._identifier here?

iceberg-python/pyiceberg/table/__init__.py

Lines 798 to 804 in a90c014

	def name(self) -> Identifier:
	"""Return the identifier of this table.
	Returns:
	An Identifier tuple of the table name
	"""
	return self.identifier

[sungwy]

Hi @Fokko, @djouallah thanks for flagging this! I think I must have missed out on updating the name method in this large deprecation exercise: https://github.com/apache/iceberg-python/pull/994/files#diff-23e8153e0fd497a9212215bd2067068f3b56fa071770c7ef326db3d3d03cee9bR1441-R1443

It also looks like .name() method is only called within the Table class's __eq__ method, so it's not obvious to me where in @djouallah code snippet this method is being called. A follow up question on my side to help with the root cause investigation @djouallah - what catalog type are you using in your example above?

[djouallah]

polaris

[kevinjqliu]

The first warning, Table.identifier property is deprecated. Please use Table.name() function instead. is from the use of Table.identifier used by the pyiceberg codebase.
See https://grep.app/search?q=.identifier&words=true&filter[repo][0]=apache/iceberg-python

The second warning, Support for parsing catalog level identifier in Catalog identifiers is deprecated., is addressed by #1326

[kevinjqliu]

Opened #1346 as a fix

[kevinjqliu]

Merged #1346, will try to get 0.8.1 out ASAP with this fix