Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the non-deprecated func to parse identifier #1326

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

kevinjqliu
Copy link
Contributor

Closes #1318
identifier_to_tuple_without_catalog is deprecated, we should remove references of it from our codebase

@kevinjqliu kevinjqliu marked this pull request as ready for review November 15, 2024 00:58
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevinjqliu Good catch, can't wait to get that deprecated code out of there :)

@kevinjqliu kevinjqliu merged commit b2f0a9e into apache:main Nov 15, 2024
7 checks passed
@kevinjqliu kevinjqliu deleted the kevinjqliu/1318 branch November 15, 2024 17:03
@kevinjqliu kevinjqliu added this to the PyIceberg 0.8.1 release milestone Nov 25, 2024
kevinjqliu added a commit to kevinjqliu/iceberg-python that referenced this pull request Nov 25, 2024
kevinjqliu added a commit that referenced this pull request Nov 27, 2024
* use the non-deprecated func (#1326)

* 0.8.0 post release steps (#1334)

* add

* fix mkdoc

* Drop upper bounds for fsspec and it's implementations (#1341)

* Drop upper bounds for fsspec and it's implementations

* Run poetry lock

* Ignore tables without `table_type` from Glue and Hive

* Ignore tables without table_type parameters while loading all iceberg table from Glue and Hive catalog (#1331)

* Use TABLE_TYPE

---------

Co-authored-by: Wenzhuo Zhao <zhaowenzhuo01@bilibili.com>

* Replace reference of `Table.identifier` with `Table.name` (#1346)

* fix Table.name

* replace Table.identifier with Table.name

* add warning filter

* Allow leading underscore in column name used in row filter (#1358)

* Update parser.py

Allow leading underscore in column name used in row filter.

* Update test_parser.py

* Update test_parser.py

* Update test_parser.py

* Remove Python 3.13 upper bound restriction (#1355)

* Remove Python 3.13 upper bound restriction

* Fix missing poetry.lock file

* Upgrading numpy on the poetry.lock file from v1.26.0 to v1.26.4

* Improve documentation for "how to release" (#1359)

* initial update

* edits

* add gpg instructions

* verify artifacts

* add twine not

* grammar

* edits

* remove old artifacts

* update doc workflow action

* and name

* add docs on patch vs major/minor release

* fix `KeyError` raised by `add_files` when parquet file doe not have column stats (#1354)

* fix KeyError, by switching del to pop

* added unit test

* update test

* fix python 3.9 compatibility, and refactor test

* update test

* bump to 0.8.1

* Add instruction for patch release (#1373)

* add instruction for patch release

* create branch from tag

* Write `null` when there is no parent-snapshot-id (#1383)

---------

Co-authored-by: Sumanth <33193748+sumanth-manchala@users.noreply.github.com>
Co-authored-by: gitzwz <72312233+gitzwz@users.noreply.github.com>
Co-authored-by: Wenzhuo Zhao <zhaowenzhuo01@bilibili.com>
Co-authored-by: vincenzon <mvcalder@gmail.com>
Co-authored-by: Luca Bigon <luca.bigon@bauplanlabs.com>
Co-authored-by: Binayak Dasgupta <binayakd86@gmail.com>
Co-authored-by: Fokko Driesprong <fokko@apache.org>
kevinjqliu added a commit to kevinjqliu/iceberg-python that referenced this pull request Nov 27, 2024
kevinjqliu added a commit that referenced this pull request Nov 27, 2024
sungwy pushed a commit to sungwy/iceberg-python that referenced this pull request Dec 7, 2024
sungwy pushed a commit to sungwy/iceberg-python that referenced this pull request Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove warnings about "Catalog identifiers" if one is not provided
2 participants