-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pydantic warning when appending data #971
Comments
This will help us avoid propagating warnings to our users, as occurred in apache#971.
Hi @sungwy, I got this warning message when I was testing the 0.7.0rc2. I have mixed feelings about not adding this to the final release. It does not raise an error, but this warning is annoying, and the fix is a simple adjustment. |
Hi @ndrluis - first off, thank you very much for jumping in and helping test out the 0.7.0 release. It's a very large release, and I'm sincerely appreciative of all your help in testing and validating this release thoroughly 🙂 I agree with your point in that although the warning is annoying and the fix is simple (and ready to commit! 🏎️ Thank you!), it thankfully isn't a critical issue that impacts the actual function. Hence, I feel that we should have this fix ready to commit, and bundle them up with either:
|
This will help us avoid propagating warnings to our users, as occurred in apache#971.
This will help us avoid propagating warnings to our users, as occurred in apache#971.
This will help us avoid propagating warnings to our users, as occurred in apache#971.
* Treat warning as error in CI/Dev This will help us avoid propagating warnings to our users, as occurred in #971. * fixup! Treat warning as error in CI/Dev
* Treat warning as error in CI/Dev This will help us avoid propagating warnings to our users, as occurred in apache#971. * fixup! Treat warning as error in CI/Dev
* Treat warning as error in CI/Dev This will help us avoid propagating warnings to our users, as occurred in apache#971. * fixup! Treat warning as error in CI/Dev
Apache Iceberg version
0.7.0rc2
Please describe the bug 🐞
In 0.7.0rc1 we don't have this problem.
Code to reproduce the warning
The append process is working but we receive this warning
The text was updated successfully, but these errors were encountered: